Skip to content

Better font unit conversion and other small fixes.

Wolthera van Hövell requested to merge woltherav/krita:text-tool-phase-2-metrics-rework-p1 into master

This does several things:

  1. It replaces the ascender and descender with the FontMetrics struct, said struct now also takes script into account (minor, necessary for later work)
  2. Then it splits the bounding box necessary for layout and the bounding box necessary for showing the path. (Bigger: this affects the bounding box shown in the UI)
  3. Then, it allows for multiple bitmaps per cluster for bitmap fonts, so that the great emoji tragedy can now be reenacted in Noto Color Emoji: emoji-family-tragedy
  4. Finally, it reworks the units to include the new font relative values for CSS-Values-4 as well as implement a converter to allow selecting various absolute lengths from KoUnit or these new relative values. This means that people can finally set the font size using pixels. (Biggest)

Test Plan

1/2: This needs a lot of testing. In particular, are any old files negatively affected by this.

3: Test 👨‍👩‍👧‍👦, backspace to make each member of the family dissappear.

4: Affected properties for units:

  • Font Size
  • Line Height
  • Baseline shift
  • Word spacing
  • Letter spacing
  • Text Indent
  • Tab Size

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Wolthera van Hövell

Merge request reports