Skip to content

Bug:501153 Brush editor live preview should ignore mirror settings

Scott Petrovic requested to merge scottpetrovic/krita:petrovic/no-mirror-brush-preview into master

Brush editor live preview: Fixed a bug to make sure mirroring is turned off. If you turn on mirroring in the toolbar now, it affects the preview in the editor.

Fixes this bug: https://bugs.kde.org/show_bug.cgi?id=501153

Test Plan

Tried various combinations of horizontal and mirroring buttons in toolbar. The mirroring did not affect the brush previews in the editor.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Scott Petrovic

Merge request reports