Skip to content

Fix and re-enable Python Palette Docker

Freya Lupen requested to merge freyalupen/krita:freyalupen/fix-pythonpalettedocker into master

The Python Palette Docker was disabled in 2019 because it had over time broken in various ways.

Unlike the C++ Palettes docker, it can export to .gpl and .svg (in the menu hidden under long-pressing the "Edit Palette Settings" button). It's also useful as a test of the Palette/PaletteView API (I fixed some issues with that as well).

Test Plan

Enable the Python Palette Docker plugin, restart Krita, show the docker.

  • Clicking swatches should change the current foreground color.
  • Swatches should be shown properly in the list.
  • Exporting to .gpl and .svg should give usable palettes.
  • Sort Colors should sort the swatches by name.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports