Fix filtering for tags with ampersands in popup palette

Stuffins Lastnamerequested to merge
stuffins/krita:popup-tag-ampersand into master

Fixes this issue where tags with &'s couldn't actually filter the popup palette's brushes because a previous fix for an accelerator-related android issue inadvertently removes user-supplied &'s when reading back the menu action's text for comparison.

Unfortunately I can't test on android so I don't know if this somehow reintroduces the original problem. I have to imagine storing the tag in user data instead of the text field is less prone to whatever shenanigans were happening, though.

(This doesn't fix the mnemonic-related appearance issue, just the actual functionality)

Test Plan

Create a brush tag with an & in its name and then confirm you can filter to its brushes in the popup palette (where before choosing such a tag would do nothing).

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports