Skip to content

Parse and write SVG title and desc elements.

Wolthera van Hövell requested to merge woltherav/krita:allow-parsing-writing-title-and-desc-elements-to-svg into master

This implements parsing and saving the title and desc elements as extra metadata on SVG shapes. The logic behind this is to make it easier to handle such metadata for resources like text style presets (as a DOM text node will have an easier time storing global scripts), as well as not destroying the data when parsing and writing SVG elements that may contain these standard SVG description elements.

This doesn't support the lang tag on these elements, but that shouldn't have to be necessary.

Test Plan

Check the unittest.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports