Skip to content

Fix TIFF file size bloating after each overwrite

Igor Danilets requested to merge alamat/krita:alamat-500870-fix into master

Unlike the stdio library TIFF image files may not be opened for both reading and writing; there is no support for altering the contents of a TIFF file. (https://libtiff.gitlab.io/libtiff/libtiff.html#basic-file-handling) However, function TIFFFdOpen do not truncate the TIFF file before the owerrite. When libtiff writes new data to existing file, the old data is not deleted.

Solution: Truncate the TIFF file before calling the function TIFFFdOpen.

Test Plan

  1. Export a TIFF image
  2. Overwrite the same TIFF image via export
  3. Repeat step 2; the file size should not change
  • Linux
  • Windows
  • Android

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Igor Danilets

Merge request reports