Skip to content

Avoid crash when clearing text pipe brushtip text

Freya Lupen requested to merge freyalupen/krita:freyalupen/bug-504781 into master

With empty text in the text brushtip in pipe mode, it crashes trying to get the brushtip, so set a dummy brushtip instead. Doesn't seem like a very correct way, but at least it avoids the crash or any safe asserts.

BUG:504781

Also, fix a warning if the brush happens to be a Color Smudge one. If the brushtip is less than 3px, (which it will be with empty text pipe with this commit, and with non-pipe mode since before this commit,) the check for a pierced brushtip goes outside the pixel range, but we don't need the check in that case.

Test Plan

  • Set a brush's brushtip to Text, set it to Pipe Mode, clear the text field. It shouldn't crash or log any warnings.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports