Skip to content

Bring back Android supporter badges

Carsten Hartenfelsrequested to merge
hartenfels/krita:feature/issue-22 into master

See commit message for more technical detail. In short: this makes in-app purchases work again, but leaves the link ot them disabled. The lifetime supporter badge shows up for people that bought it.

Owners of the badge will see this:

Supporter badge

The link to buy the supporter badge is not currently shown, but if it were, it would currently look like this:

Purchase link for a supporter badge

Which then (for me in Germany) will show this terribly worded message from Google that makes it sound like they will immediately enter the user into some kind of contract without even telling them what for. They just show me this because I would normally be allowed to revoke online purchases within 30 days, but the way they say "immediately" it makes it sound like something is going to happen immediately after I press agree.

This means that we must show the user the price of the product before starting the billing flow, otherwise we're very likely to lose them here because they get spooked by the message and won't move to the next step to actually see the purchase options. This isn't a technical problem, the billing service tells us the price, it's just a major concern for how we're going to design things.

Awful Google Play message

And then after clicking past that, I get the option to buy the badge, plus some tester stuff.

Purchase dialog

Test Plan

  • If you own a supporter badge, observe its presence on the start screen. If not, observe that it's not there.
  • Observe that in both cases there is no link to buy a supporter badge.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Carsten Hartenfels

Merge request reports