Skip to content

Change the error to WriteError in case of NoError

Agata Cackorequested to merge
tymond/krita:tiar/fix_issue_33_crash_on_saving_file_android_better into master
  • The first commit ensures that the code never tries to create an KisImportExportErrorCode with a "no error" error code.
  • The second commit ensures that KisImportExportErrorCode won't just crash on Android even if it gets a "no error" as the initialization error code by changing the asserts to safe asserts and assigning a reasonable generic error code.

Test Plan

Try to save into an unavailable location maybe to trigger the issue?

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports