Android: fullscreen main window by default

Carsten Hartenfelsrequested to merge
hartenfels/krita:feature/androidfullscreen into master

Because that's the sensible thing to do for a productive application like Krita. Similar applications do it as well, so there shouldn't be an issue of users not understanding how to exit it or whatever.

The switch happens inside showEvent so that we don't need to worry about the different ways the main window may be shown. I'm not sure if this really matters on Android, since it can only ever have one main window, but it's easier to maintain if it's only in one spot anyway.

This also gets rid of the back button exiting fullscreen mode. It really doesn't need to be elevated to a dedicated hardware button and I mostly just activate it on accident if I'm trying to back out of a series of dialogs or something.

It also removes the fullscreen toggle button that existed in the status bar on Android. I didn't even know it existed until @woltherav mentioned it could be removed if the window defaulted to fullscreen, which I agree with.

You can still exit fullscreen through the View menu if you really want to, which is more than most other applications give you.

Test Plan

  • Start Krita on Android.
    • Observe that it fullscreens the main window automatically.
    • Observe that the status bar doesn't have a fullscreen button on Android.
    • Check that View > Full Screen still works.
  • Start Krita on an operating system different from Android.
    • Observe that fullscreen behavior didn't change.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports