Touch and hold for color picking

Carsten Hartenfelsrequested to merge
hartenfels/krita:feature/touchcolorpicker into master

The primary purpose of this is to add a one-finger press-and-hold gesture for color picking. This was requested by Ramon and several other people. That comes with a bunch of ancillary changes.

It changes the way the color picking preview looks because the existing style would just get covered by your hand if you're right-handed. It's now a circle instead, like it is in several other programs, which is not sensitive to handedness.

I fixed BUG:347799 just by rotating/mirroring/flipping the contents of the preview. It being a circle made that pretty trivial.

It also fixes the "color sampler" touch shortcut not working, it referenced an action that didn't exist.

Test Plan

  • Sample a color. Observe that the color preview is a circle now.
  • Rotate and/or mirror the canvas, then sample a color. Observe that the color preview orients itself properly.
  • Have the canvas input settings set to defaults. Touch and hold on the screen in one spot, observe that it samples a color.
  • Under "Touch Gestures", set some gesture to "Color Sampler". Observe that it now switches to the color sampler tool instead of doing absolutely nothing.
    • This is not related to sampling a color by touching and holding! It's just a tool switch shortcut that wasn't working.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Carsten Hartenfels

Merge request reports