Create a qquickwidget based popup for handling popups with qquickwidgets.

Wolthera van Hövellrequested to merge
woltherav/krita:qml_qwidget_popup into master

Regular QML popups don't work properly with qquickwidget. Even qt6' popup-type crashes when used with qquickwidget, so this is a workaround that falls back to a regular popup when not in qquickwidget.

While this is not required for 5.3, it would be nice to have.

TODO:

  • Make resource dropdowns work with the auto-complete menu. This will require a separate popup.
  • Ensure it doesn't crash in qt6

Test Plan

Interact with the font dropdown in the text properties docker, or the style preset selector. Without this, those popups will be cropped by their docker, with this, they'll become a nice popup.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?
Edited by Wolthera van Hövell

Merge request reports