fix Node::setChildNodes

Stuffins Lastnamerequested to merge
stuffins/krita:fix-set-child-nodes into master

Fixes the bug from this k-a thread with the python Node.setChildNodes method. Previously it would only remove its first child before adding the new ones, as nextSibling of an orphan node is null.

Test Plan

This should now clear all children of the active node

Krita.instance().activeDocument().activeNode().setChildNodes([])

And this is the code from that thread that should insert a new sibling node just below the active one

app = Krita.instance()

doc = app.activeDocument()
node = doc.activeNode()

parent = node.parentNode()
if parent:
    children = parent.childNodes()
    
    new_layer = doc.createNode("SCRIPTED", "paintLayer")
    idx = node.index()
    children.insert(idx, new_layer)
    
    parent.setChildNodes(children)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports