Make shortcut input work properly

Carsten Hartenfelsrequested to merge
hartenfels/krita:feature/bug-462919 into master

This makes the key sequence input not think the user is holding modifiers for all eternity when using a physical keyboard on Android.

It also fixes the clear button not having any icon (on all platforms) along the way.

BUG:462919

Test Plan

  • Navigate to Settings → Configure Krita → Keyboard Shortcuts and pick a shortcut to edit.
  • Observe that the clear button has an icon instead of being a blank button.
  • Click on the key sequence input and press a key combination with a modifier, such as Ctrl+1. Release the keys. Observe that the widget realizes that you let go of the modifier and applies the shortcut instead of showing "Ctrl+…" forever.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports