Support curves in RemoveGutter in KnifeTool

Agata Cackorequested to merge
tymond/krita:tiar/fix_curves_in_knife_tool into master
  • Add missing switch case to VectorPath constructor
  • Cancel removing gutter when going over a whole shape
  • Use isInsideShape in mergeShapesWithGutter
  • Fix crash on wrong indexes in RemoveGutter in KnifeTool
  • Add isInsideShape to KisAlgebra2D
  • Agata Cacko Add debug for VectorPath and VectorPathPoint
  • Add segments and index conversion to VectorPath

Test Plan

There are unit tests for some of the functions. Also test bug 512601.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports