Fix multitouch on Xiaomi Pad devices

Carsten Hartenfelsrequested to merge
hartenfels/krita:feature/bug-510993 into master

Xiaomi Pad devices always cancel touches made with more than two fingers. The input manager now treats those as if the user ended those touches normally instead of having cancelled them. "Normal" Android devices never cancel these events as far as I can tell, so it should not have a negative effect on those.

This also removes the event compression from the touch shortcut compression because, as far as I can tell, its behavior is straight-up incorrect in this case. It loses events and then triggers the wrong shortcut because the shortcut handler didn't get the memo that the number of fingers has changed. Event compression is still used for touch painting that will hit the tools, it's only removed from the shortcut handling path.

BUG:510993

Test Plan

  • Use 3 and 4 finger tap shortcuts on a Xiaomi Pad device. Observe that they work, rather than doing squat.
  • Use tap shortcuts on other devices. Observe that they continue to work as before.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports