[android] Make touch scrolling not trigger menu

Carsten Hartenfelsrequested to merge
hartenfels/krita:feature/bug-513413 into master

When setting the kinetic scroll gesture to touch drag on Android, it doesn't actually delay the emulation of mouse events, so we must not subtract the kinetic scroll delay from the long-press emulation or else we end up instantly opening the context menu.

This does NOT fix the generally-weird behavior of setting the kinetic scroll gesture to touch on Android cause by it simultaneously scrolling and inputting mouse events.

BUG:513413

Test Plan

Set kinetic scrolling to be on touch drag on Android. Restart Drawpile. Observe that context menus no longer open instantly when touching or clicking on something scrollable such as the layer list.

(Again: the generally weird behavior of touch kinetic scrolling on Android is unchanged. That's a problem in Qt from it not delaying mouse emulation correctly.)

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports