Xiaomi workarounds

Carsten Hartenfelsrequested to merge
hartenfels/krita:feature/xiaomi into master

Various workarounds for Xiaomi devices. Manual MR: documentation/docs-krita-org!379 (merged)

  • Translate page up and page down presses to right and middle mouse buttons, because their stylus inexplicably inputs those keys when pressing the side buttons.
  • Ignore historic tablet motion events, because they are badly interpolated, jaggy garbage.
  • Use a steeper default pressure curve because attaining the maximum pressure their stylus requires is effectively not humanly possible.

These can all be changed in the tablet settings.

Tablet settings

Comparison with workarounds off versus on.

Stroke result comparison

Test Plan

  • Observe that these settings turn on by default on Xiaomi devices and don't on others.
  • Toggle the page up/down setting. Observe that pressing those keys now inputs right and middle mouse buttons. Observe that with a Xiaomi stylus, the side buttons now do that.
  • Enable the historic tablet event workaround. On a Xiaomi device, observe that e.g. a basic smoothed line now doesn't look as ragged anymore. On other devices, it probably just makes the lines more jagged.
  • See that you can actually reach maximum pressure with a Xiaomi stylus with the new default curve.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports