Add error messages to the Transform Tool

Agata Cackorequested to merge
tymond/krita:tiar/add_error_messages_to_transform_tool into master

Before this commit, the Transform Tool wouldn't show any error indication when the user attempted to transform a set of layers that contained a locked or hidden layer, but the tool would still refuse to work. This commit adds error messages so at least the user is aware why the tool refuses to work.

NOTE 1: This will break the soft string freeze and should be merged before the hard string freeze. NOTE 2: Would be possible to enable transforming hidden layers, but the error message for locked layers needs to be included (breaking the freeze) regardless.

Test Plan

  1. Create a document with layers, some of them hidden.
  2. Select multiple layers, including the one hidden.
  3. Try to transform it. It should show an error message. (Before this patch it would not show anything).

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports