Make KisPopupButton popup work properly
- Removed the double frame when assigning a QMenu as the popup widget.
- Compensated for assigned QMenus hiding themselves because they're not happy about not being a top-level popup.
- Make these popups fall back to the screen that the button is on when no screen is set on the frame yet, rather than throwing it on the primary monitor.
- Make the logic from !2500 (merged) conditional for detached popups so that attached popups size themselves properly on first open.
https://krita-artists.org/t/brush-preset-docker-menu-empty-5-3-0-prealpha-android/163235
Test Plan
- Open the brush presets view options popup. Observe that:
- It has only a single frame instead of two.
- It sizes itself properly on first open.
- It shows up on the correct monitor on first open.
- The contents don't disappear anymore when you click on a separator.
- Test !2500 (merged) again.
Formalities Checklist
- I confirmed this builds.
- I confirmed Krita ran and the relevant functions work.
- I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
- I made sure my commits build individually and have good descriptions as per KDE guidelines.
- I made sure my code conforms to the standards set in the HACKING file.
- I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
- Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?
Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.