[android] Make dialogs that contain QtQuick widgets work properly

Carsten Hartenfelsrequested to merge
hartenfels/krita:feature/bug-515662 into master

This changes the QtQuick backend on Android to use the software renderer because the hardware renderer does not support proper stacking. This leads to windows with QtQuick widgets to always end up behind all "normal" windows, including our own dialog decorations. This fixes BUG:515662.

This change reintroduces BUG:488606 where the window doesn't refresh when opening a new document. I found a better way to hack around this that works fine on both the Samsung and Xiaomi tablet I have though, by just resizing the window slightly larger and then makes it smaller again, which has no apparent flicker and doesn't cause bars to appear on the latter device.

Lastly, this also changes the style properties dialog to be allocated on the stack so that it actually gets freed. This isn't Android-specific, it was just a leak.

Test Plan

  • Open a document. Observe that it shows up cleanly, without having to fiddle with the menus or rotate the screen.
  • In the text properties dock, open the text property config dialog (bottom-right button on the Paragraph and Character tabs) or css style edit dialog ("+" button on the Preset tab). Observe that you can see the dialog contents instead of them going behind the white border window.
  • Undock the text properties dock. Undock another dock. Observe that the most recent dock you touch stacks in front, instead of the text properties dock always staying at the bottom.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports