Don't scroll palette on foreground change

Carsten Hartenfelsrequested to merge
hartenfels/krita:feature/nopalettescroll into master

When having a palette that is larger than the view, the automatic selection of the closest color causes the palette's scroll window to jitter erratically. This patch prevents it.

See this video for the behavior this prevents: https://drive.google.com/file/d/11EbBHKOo01TdbG2PkT8B9vvdYHoyNfMJ/view?usp=drive_link

Test Plan

  • Open the palette docker and a palette that is so large it needs to scroll.
  • Change the foreground color. Observe that the palette doesn't scroll to the closest selected color.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports