Add option to fixate the angle of sRGB triangle selector in popup palette

Dat Lerequested to merge
dootdoot/krita:dootdoot/norotatepicker into master

Hi, I added an option in the Popup Palette settings to allow fixating the angle of the sRGB Triangle Selector

Here's the KA thread requesting the feature: https://krita-artists.org/t/can-we-stop-spinning-the-triangular-color-selector-in-popup-palette/53545

Before this, the sRGB Triangle Selector will rotate depending on the currently selected hue. By enabling this option, the user can set the rotation angle of the sRGB Triangle Selector regardless of the current selected hue

image.png

Before (sRGB Triangle Selector moving with hue):

image.png

After (Rotation angle = 0)

image.png

Test Plan

  1. Enable the Fix sRGB Triangle Selector Rotation option
  2. Try changing hue to make sure the selector doesn't rotate
  3. Change the Rotation Angle settings and clicks OK
  4. Make sure the selector angle changed accordingly
  5. Disable the Fix sRGB Triangle Selector Rotation option
  6. Try changing hue to make sure the selector rotate with hue

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Dat Le

Merge request reports