[android] Don't rely on QFileInfo::isWritable

Carsten Hartenfelsrequested to merge
hartenfels/krita:feature/nowritecheck into master

Because it lies. Some systems just always return false when you ask them whether a file is writable. This takes out the check in that regard, which means the user will get an error about the file not being writable at the very end of the saving process. Which isn't optimal, but it's better than not being able to save anything at all.

See https://krita-artists.org/t/cannot-save-file-on-android-device/170413

Test Plan

  • Save a file on Android. Observe that it no longer says that the file can't be written to if you have a storage provider that lies about writability of files.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports