Qt6: Fix app translations

Freya Lupenrequested to merge
freyalupen/krita:freyalupen/bug-517257 into master

i18n() must be called after KLocalizedString::setApplicationDomain() (which is meant to be called "right after creating the instance of QCoreApplication"), or app translations will not work, even afterward apparently.

So this moves setting the KAboutData to after setting up translations, which shouldn't cause any problems.

This also fixes translations on Android without need for the if-def'd reversion from MR!2700.

Test Plan

On Qt6 or Android, Settings->Configure Language... to something other than American English, restart Krita. Krita should show translations from that language.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports