Allow reading and writing cicp values from icc profiles.

Wolthera van Hövellrequested to merge
woltherav/krita:cicp-for-icc-profiles into master

Part of #86 .

This adds CICP reading and writing to our icc profile code. CICP values in ICC are a thing that's new since ICC 4.4, and it's useful as it allows us to streamline testing CICP values, and allows for an ICC profile that can signal it is a rec2100 profile in a specification correct manner.

It then adds a Rec2100pq profile made in such a manner.

To Do

  • The new profile and similar profiles should be plugged into the color management chain, or at the least be replaced accordingly.
  • Write the AToB and BToA tags of the new profile, so we have a good fallback. This requires creating a LUT to scale values after the dummy curve.
  • Probably need to have a check to ensure the new profile calls itself "Krita Rec. 2100 Perceptual Quantizer" to avoid any unnecessary confusion.

Test Plan

  • Check the new "Krita Rec. 2020 Perceptual Quantizer ICC" profile in the color space browser.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
    • Test that CICP values are written and read correctly.
    • Test that the new profile has a reproducable uniqueID.
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Wolthera van Hövell

Merge request reports