518235-Out-of-Bounds-Selection-Inversion

Ricky Ringlerrequested to merge
rickyringler/krita:518235-Out-of-Bounds-Selection-Inversion into master

When inverting a selection with any of the selection tools, but notably the rectangle tool, we're using the default bounds, causing inverted selections to grab more pixels than what the user selected with the KisSequentialIterator.

For example: When a selection was 2840x1928 pixels, inverting the selection created a selection of 2880x1984.

We should just use the image's actual extent.

Closes #518235

Test Plan

  • Tested rectangle inversion while entire selection was NOT inside the canvas.
  • Tested rectangle inversion while entire selection was inside the canvas but not the same size as the canvas.
  • Tested rectangle inversion while selection was the same size as the canvas.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Edited by Ricky Ringler

Merge request reports