Revert keyframe selection changing layer selection

Carsten Hartenfelsrequested to merge
hartenfels/krita:feature/revertkeyframeselection into master

This reverts commit 8965a0dd because the logic is broken, it will react to any change of the current index, not just ones that are initiated by the user interacting with the timeline. That causes all sorts of mayhem, like switching between documents changing the layer selection, opening a file selecting the wrong layer and moving through the layer list with the arrow keys causing various weird effects on the current and selected layer.

This would be fixable by detecting whether the user triggered the change via the timeline, but that's sufficiently complicated that it'll need more testing first. The bugs this change causes are too major, so just reverting it for now.

BUG:520718 BUG:520723 BUG:520744

Test Plan

See linked bugs.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports