Filter out bogus selection mask data loss warning

Carsten Hartenfelsrequested to merge
hartenfels/krita:feature/selectionwarnings into master

When attempting to save a document with a selection active to a format that doesn't support saving selections, the user gets a bogus data loss warning that says:

The image contains layers of unsupported type Selection Mask. Only the rendered result will be saved.

This is pretty nonsensical for the user. They won't know what a "selection mask layer" is, it's just an ephemeral selection to them. Talking about the "rendered result" is lies because the selection mask will simply not be saved at all.

We could fix the warning message, but really, it shouldn't exist. It's an ephemeral selection, users don't expect it to be retained and are pretty unlikely to shed a tear about it. So this change just filters out the warning. This is better than inundating the user with warnings that don't matter because it trains them that they should ignore warnings and makes actual data loss more likely.

Test Plan

Create a selection, save as a file format that doesn't support saving selections, such as PSD. Observe that you don't get the warning about the selection not being saved.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
  • Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?

Reminder: the reviewer is responsible for merging the patch, this is to ensure at the least two people can build the patch. In case a patch breaks the build, both the author and the reviewer should be contacted to fix the build. If this is not possible, the commits shall be reverted, and a notification with the reasoning and any relevant logs shall be sent to the mailing list, kimageshop@kde.org.

Merge request reports