Loading
Fix Inconsistency in canvas taking keyboard focus from timeline
Solves: Bug 526208
This commit changes two things:
- It makes the canvas controller not swallow inputs that it's supposed to ignore.
- It also makes it so in an animated image, the change frame action will change the current frame regardless of if the selected layer is animated or not.
Test Plan
- Create an image
- Switch to animation timeline
- Make a few frames in one layer
- Try switching between them with the arrow keys
- Make a layer outside the timeline
- Change the frames with the arrows again (this should not work in master)
Formalities Checklist
- I confirmed this builds.
- I confirmed Krita ran and the relevant functions work.
- I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
- I made sure my commits build individually and have good descriptions as per KDE guidelines.
- I made sure my code conforms to the standards set in the HACKING file.
- I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.
- Does the patch add a user-visible feature? If yes, is there a documentation MR ready for it at Krita Documentation Repository?
(I'm not sure how to do a unit test.)
Edited by Iris Hormoviti