Skip to content

Add the angle selector to the pop up palette

Deif Lou requested to merge deiflou/krita:deiflou/angle_selector_on_popup into master

This adds a mechanism so that paintop properties can have a subtype associated with them (for example "angle", "color", etc.). Right now it is used to indicate if a int/double property is an angle. Then that information is used to dynamically use a slider or an angle selector widget.

angle_selector_in_pup_01angle_selector_in_pup_02

Test Plan

Select differen brushes from different brush engines and right click on the canvas to bring up the pop up palette. Then show the angle properties. They should use now the angle selector.

Formalities Checklist

  • I confirmed this builds.
  • I confirmed Krita ran and the relevant functions work.
  • I tested the relevant unit tests and can confirm they are not broken. (If not possible, don't hesitate to ask for help!)
  • I made sure my commits build individually and have good descriptions as per KDE guidelines.
  • I made sure my code conforms to the standards set in the HACKING file.
  • I can confirm the code is licensed and attributed appropriately, and that unattributed code is mine, as per KDE Licensing Policy.

Merge request reports