libkexiv2 issueshttps://invent.kde.org/graphics/libkexiv2/-/issues2022-11-14T01:13:55Zhttps://invent.kde.org/graphics/libkexiv2/-/issues/4Proposal: Move to Frameworks as this isn't a program2022-11-14T01:13:55ZJustin ZobelProposal: Move to Frameworks as this isn't a programhttps://invent.kde.org/graphics/libkexiv2/-/issues/321.04.2: compile time warnings2021-06-17T16:29:04ZTomasz Kloczko21.04.2: compile time warningsgcc 11.1.1
```
/home/tkloczko/rpmbuild/BUILD/libkexiv2-21.04.2/src/kexiv2exif.cpp: In member function 'bool KExiv2Iface::KExiv2::rotateExifQImage(QImage&, KExiv2Iface::KExiv2::ImageOrientation) const':
/home/tkloczko/rpmbuild/BUILD/libke...gcc 11.1.1
```
/home/tkloczko/rpmbuild/BUILD/libkexiv2-21.04.2/src/kexiv2exif.cpp: In member function 'bool KExiv2Iface::KExiv2::rotateExifQImage(QImage&, KExiv2Iface::KExiv2::ImageOrientation) const':
/home/tkloczko/rpmbuild/BUILD/libkexiv2-21.04.2/src/kexiv2exif.cpp:917:34: warning: 'QImage QImage::transformed(const QMatrix&, Qt::TransformationMode) const' is deprecated: Use transformed(const QTransform &matrix, Qt::TransformationMode mode) [-Wdeprecated-declarations]
917 | image = image.transformed(matrix);
| ~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /usr/include/qt5/QtGui/QImage:1,
from /home/tkloczko/rpmbuild/BUILD/libkexiv2-21.04.2/src/kexiv2.h:26,
from /home/tkloczko/rpmbuild/BUILD/libkexiv2-21.04.2/src/kexiv2exif.cpp:8:
/usr/include/qt5/QtGui/qimage.h:288:12: note: declared here
288 | QImage transformed(const QMatrix &matrix, Qt::TransformationMode mode = Qt::FastTransformation) const;
| ^~~~~~~~~~~
/home/tkloczko/rpmbuild/BUILD/libkexiv2-21.04.2/tests/setiptcpreview.cpp: In function 'int main(int, char**)':
/home/tkloczko/rpmbuild/BUILD/libkexiv2-21.04.2/tests/setiptcpreview.cpp:39:30: warning: 'QImage QImage::transformed(const QMatrix&, Qt::TransformationMode) const' is deprecated: Use transformed(const QTransform &matrix, Qt::TransformationMode mode) [-Wdeprecated-declarations]
39 | image = image.transformed(matrix);
| ~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from /usr/include/qt5/QtGui/QImage:1,
from /home/tkloczko/rpmbuild/BUILD/libkexiv2-21.04.2/tests/setiptcpreview.cpp:12:
/usr/include/qt5/QtGui/qimage.h:288:12: note: declared here
288 | QImage transformed(const QMatrix &matrix, Qt::TransformationMode mode = Qt::FastTransformation) const;
| ^~~~~~~~~~~
```https://invent.kde.org/graphics/libkexiv2/-/issues/221.04.2: no documemtation?2021-06-16T21:56:35ZTomasz Kloczko21.04.2: no documemtation?Looks like cmake do not support BUILD_QCH=ON.Looks like cmake do not support BUILD_QCH=ON.https://invent.kde.org/graphics/libkexiv2/-/issues/1Issues while porting Gwenview to KExiv22020-10-25T12:50:48ZTom MoebertIssues while porting Gwenview to KExiv2Hi,
I started to revise Exif support of Gwenview and someone has pointed me to this project. I want to incorporate KExiv2 into Gwenview. While this looks promising, there are a few issues that keep me from doing so:
1. You're catching ...Hi,
I started to revise Exif support of Gwenview and someone has pointed me to this project. I want to incorporate KExiv2 into Gwenview. While this looks promising, there are a few issues that keep me from doing so:
1. You're catching away all exceptions and do not provide a way to retrieve the error reported by exiv2. If an error occurs, it should not go lost in the console logs. Instead, I want the ability to set its message as `documentErrorString`.
1. You provide a wrapper for `Save(QString)`, but for Gwenview we need a `Save(QIODevice)` overload as well, [like this](https://invent.kde.org/tommo/gwenview/-/blob/7bb7d061ca293915650a334e601368924e172d29/lib/exiv2imageloader.cpp#L132-180).
Also, why are functions like
* `load()`
* `loadFromData()`
* `setFilePath()`
and many more setters marked as `const`? They are making changes to the underlying object. They shouldn't be const, IMO.
My current work-in-progress can be found here: https://invent.kde.org/tommo/gwenview/-/tree/jpegcontent2