Issues while porting Gwenview to KExiv2
Hi,
I started to revise Exif support of Gwenview and someone has pointed me to this project. I want to incorporate KExiv2 into Gwenview. While this looks promising, there are a few issues that keep me from doing so:
- You're catching away all exceptions and do not provide a way to retrieve the error reported by exiv2. If an error occurs, it should not go lost in the console logs. Instead, I want the ability to set its message as
documentErrorString
. - You provide a wrapper for
Save(QString)
, but for Gwenview we need aSave(QIODevice)
overload as well, like this.
Also, why are functions like
load()
loadFromData()
setFilePath()
and many more setters marked as const
? They are making changes to the underlying object. They shouldn't be const, IMO.
My current work-in-progress can be found here: https://invent.kde.org/tommo/gwenview/-/tree/jpegcontent2