Skip to content
  • Elvis Angelaccio's avatar
    Don't use exec() to open dialogs · 40afb829
    Elvis Angelaccio authored
    Summary:
    exec() is blocking and should not be used if possible.
    
    Currently it makes impossible to interact with a 2nd okular window
    if the first window has the Properties or Embedded Files dialog open.
    
    It also causes a double delete crash when closing okular via dbus
    while either of those dialogs is open.
    
    We can use open() instead which does not block the event loop and fixes
    both the problems.
    
    Test Plan:
    1. Open the Properties or Embedded Files dialog, then close okular via dbus.
    2. Open two okular windows, then open the Properties or Embedded Files dialog in one of them and try to use the other window.
    
    Reviewers: #okular
    
    Tags: #okular
    
    Differential Revision: https://phabricator.kde.org/D8704
    40afb829