Commit 51d91bfd authored by Nate Graham's avatar Nate Graham
Browse files

Automatically enable and disable "Force Rasterization" when required

Okular implements various print scaling options that require the use of
the "Force rasterization" feature or else they have no effect. However
this is not communicated in the UI anywhere or handled automatically,
leading to users being confused and frustrated when the print scaling
option they chose didn't work. It wastes paper too.

This commit causes the "Force rasterization" checkbox to become checked
automatically whenever the user selects a print scaling option that
requires it, and unchecked if they return to the default scaling mode
that does not require it.

BUG: 434247
FIXED-IN: 21.08.2
parent 6b978a55
Pipeline #82362 passed with stage
in 27 minutes and 3 seconds
...@@ -107,6 +107,11 @@ public: ...@@ -107,6 +107,11 @@ public:
m_scaleMode->setToolTip(i18n("Scaling mode for the printed pages")); m_scaleMode->setToolTip(i18n("Scaling mode for the printed pages"));
printBackendLayout->addRow(i18n("Scale mode:"), m_scaleMode); printBackendLayout->addRow(i18n("Scale mode:"), m_scaleMode);
// If the user selects a scaling mode that requires the use of the
// "Force rasterization" feature, enable it automatically so they don't
// have to 1) know this and 2) do it manually
connect(m_scaleMode, QOverload<int>::of(&QComboBox::currentIndexChanged), this, [=](int index) { m_forceRaster->setChecked(index != 0); });
layout->addWidget(formWidget); layout->addWidget(formWidget);
layout->addStretch(1); layout->addStretch(1);
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment