Enable a CI with clang-tidy and modernize-redundant-void-arg

.gitlab-ci.yml

@@ -16,3 +16,20 @@ build_ubuntu_18_04:
     - mkdir -p build && cd build
     - cmake -G Ninja ..
     - ninja
+
+build_clang_tidy:
+  stage: build
+  image: debian:unstable
+  only:
+    - merge_requests
+  before_script:
+    - echo 'deb-src http://deb.debian.org/debian unstable main' >> /etc/apt/sources.list
+    - apt-get update
+    - apt-get build-dep --yes --no-install-recommends okular
+    - apt-get install --yes --no-install-recommends ninja-build clang clang-tidy python python-yaml libkf5crash-dev libkf5purpose-dev
+
+  script:
+    - mkdir -p build && cd build
+    - CC=clang CXX=clang++ cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -G Ninja ..
+    - ninja
+    - "run-clang-tidy -header-filter='.*' -checks='-*,modernize-redundant-void-arg' -config=\"{WarningsAsErrors: '*'}\""

generators/dvi/TeXFontDefinition.h

@@ -147,7 +147,7 @@ class TeXFontDefinition {
   font_type     fontType;
 
   // Functions related to virtual fonts
-  void          read_VF_index(void );
+  void          read_VF_index();
 };
 
 #endif

generators/dvi/fontMap.h

@@ -88,7 +88,7 @@ class fontMap {
       using the kpsewhich command, or if it cannot be read, or is
       (partially) in an improper format, an error message is printed
       to stderr using the kDebug() stream. */
-  fontMap( void );
+  fontMap();
 
   /** find the name of a font file (e.g. 'ubkd8a.pfb') from a TeX font
       name (e.g. 'rpbkd'). This method return a reference to

generators/fax/faxexpand.h

@@ -114,7 +114,7 @@ void g32expand(class pagenode *pn, drawfunc df);
 void g4expand(class pagenode *pn, drawfunc df);
 
 /* initialise code tables */
-extern void fax_init_tables(void);
+extern void fax_init_tables();
 
 /* count lines in image */
 extern int G3count(class pagenode *pn, int twoD);

generators/fax/faxinit.cpp

@@ -315,7 +315,7 @@ FillTable(struct tabent *T, int Size, const struct proto *P, int State)
 
 /* initialise the huffman code tables */
 void
-fax_init_tables(void)
+fax_init_tables()
 {
     static bool already_initialized = false;
     if (already_initialized) {