Commit 89a8cfc0 authored by Kishore Gopalakrishnan's avatar Kishore Gopalakrishnan Committed by Albert Astals Cid
Browse files

Take into account the label size while setting size of the page number box.

parent 86a600ff
......@@ -93,9 +93,22 @@ void MiniBarLogic::notifySetup(const QVector<Okular::Page *> &pageVector, int se
const QString pagesString = QString::number(pages);
// In some documents, there may be labels which are longer than pagesString. Here, we check all the page labels, and if any of the labels are longer than pagesString, we use that string for sizing m_pageLabelEdit
QString pagesOrLabelString = pagesString;
if (labelsDiffer) {
for (const Okular::Page *page : pageVector) {
if (!page->label().isEmpty()) {
MiniBar *miniBar = *m_miniBars.constBegin(); // We assume all the minibars have the same font, font size etc, so we just take one minibar for the purpose of calculating the displayed length of the page labels.
if (miniBar->fontMetrics().horizontalAdvance(page->label()) > miniBar->fontMetrics().horizontalAdvance(pagesOrLabelString)) {
pagesOrLabelString = page->label();
for (MiniBar *miniBar : qAsConst(m_miniBars)) {
// resize width of widgets
miniBar->resizeForPage(pages, pagesOrLabelString);
// update child widgets
......@@ -189,7 +202,7 @@ MiniBar::MiniBar(QWidget *parent, MiniBarLogic *miniBarLogic)
// resize width of widgets
resizeForPage(0, QString());
// connect signals from child widgets to internal handlers / signals bouncers
connect(m_pageNumberEdit, &PageNumberEdit::returnPressed, this, &MiniBar::slotChangePageFromReturn);
......@@ -280,13 +293,14 @@ void MiniBar::slotToolBarIconSizeChanged()
void MiniBar::resizeForPage(int pages)
void MiniBar::resizeForPage(int pages, const QString &pagesOrLabelString)
const int numberWidth = 10 + fontMetrics().horizontalAdvance(QString::number(pages));
const int labelWidth = 10 + fontMetrics().horizontalAdvance(pagesOrLabelString);
m_pageNumberEdit->setMaximumWidth(2 * numberWidth);
m_pageLabelEdit->setMaximumWidth(2 * numberWidth);
m_pageLabelEdit->setMaximumWidth(2 * labelWidth);
m_pageNumberLabel->setMaximumWidth(2 * numberWidth);
......@@ -132,7 +132,7 @@ public Q_SLOTS:
void slotToolBarIconSizeChanged();
void resizeForPage(int pages);
void resizeForPage(int pages, const QString &pagesOrLabelString);
bool eventFilter(QObject *target, QEvent *event) override;
MiniBarLogic *m_miniBarLogic;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment