Commit 91dbaa1f authored by Albert Astals Cid's avatar Albert Astals Cid
Browse files

Set focus to the next current tab when closing the current tab

And by that it means giving the focus to the pageview which is most of
the fimes what we want. One could argue that if i had the focus on the
searchbar we should restore the focus there, but that makes not much
sense to me, since each tab is it's own world, at most one could say,
let's remember where the focus was in that tab the last time it was
focused and restore it there, but it seems a bit convoluted.

To be able of setting the focus to the pageview from the shell we need
to set up some focus proxies, so that part->widget (which is the sidebar)
ends up giving the focus to the pageview, which is what makes sense if
someone says "you part, set yourself the focus"

BUGS: 428257
parent a66a18b8
Pipeline #38882 passed with stage
in 18 minutes and 32 seconds
......@@ -506,6 +506,7 @@ Part::Part(QWidget *parentWidget, QObject *parent, const QVariantList &args)
m_pageView = new PageView(rightContainer, m_document);
QMetaObject::invokeMethod(m_pageView, "setFocus", Qt::QueuedConnection); // usability setting
// m_splitter->setFocusProxy(m_pageView);
connect(, &PageView::rightClick, this, &Part::slotShowMenu);
......@@ -290,6 +290,18 @@ void Shell::openUrl(const QUrl &url, const QString &serializedOptions)
void Shell::closeUrl()
// When closing the current tab two things can happen:
// * the focus was on the tab
// * the focus was somewhere in the toolbar
// we don't have other places that accept focus
// * If it was on the tab, logic says it should go back to the next current tab
// * If it was on the toolbar, we could leave it there, but since we redo the menus/toobars for the new tab, it gets kind of lost
// so it's easier to set it to the next current tab which also makes sense as consistency
if (m_tabWidget->count() >= 0) {
KParts::ReadWritePart *const newPart = m_tabs[m_tabWidget->currentIndex()].part;
void Shell::readSettings()
......@@ -110,6 +110,7 @@ void Sidebar::setMainWidget(QWidget *widget)
// setting the splitter as parent for the widget automatically plugs it
// into the splitter, neat!
if (!d->splitterSizesSet) {
QList<int> splitterSizes = Okular::Settings::splitterSizes();
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment