1. 16 May, 2020 1 commit
  2. 04 Mar, 2020 1 commit
  3. 21 Feb, 2020 2 commits
  4. 20 Feb, 2020 1 commit
  5. 19 Feb, 2020 3 commits
  6. 10 Feb, 2020 1 commit
  7. 26 Jan, 2020 1 commit
  8. 19 Jan, 2020 1 commit
  9. 11 Jan, 2020 1 commit
  10. 07 Jan, 2020 1 commit
    • Albert Astals Cid's avatar
      "Fix" PartTest::testAdditionalActionTriggers · 45303be6
      Albert Astals Cid authored
      By waiting for the delayResizeEventTimer to trigger before starting the
      test.
      
      The test "randomly" failed before, which shows there's an actual bug in
      the code, but the actual bug is "if you are moving the mouse over a
      field that has a on focus action and at that very same time the
      delayResizeEventTimer triggers, the action won't be executed".
      
      That's almost impossible to reproduce in real life so i'm going to
      pretend the bug is not there for all purposes
      45303be6
  11. 28 Dec, 2019 2 commits
  12. 23 Dec, 2019 1 commit
  13. 18 Dec, 2019 1 commit
    • Albert Astals Cid's avatar
      CI: enable more modernize checks · 78cf6bd9
      Albert Astals Cid authored
      Since unfortunately some of the autogenerated includes don't pass the
      checks we do a trick of building out of source and then specifying the
      .*/okular/.* path as the only includes we care about
      78cf6bd9
  14. 02 Nov, 2019 1 commit
  15. 02 Oct, 2019 1 commit
  16. 01 Aug, 2019 2 commits
  17. 27 Jul, 2019 1 commit
  18. 17 Jul, 2019 1 commit
  19. 27 May, 2019 2 commits
  20. 29 Nov, 2018 1 commit
    • Tobias Deiminger's avatar
      Fix inconsistent viewport positioning in PageView · a29e4eaf
      Tobias Deiminger authored
      Summary:
      This diff unifies the calculation of the viewport position from a given DocumentViewport. PageView::notifyViewportChanged and PageView::slotRelayoutPages used to handle it differntly, which resulted in viewport jumps for no reason.
      
      It happened in various situations, e.g. when jumping to a page using the footer page navigation, or when reloading the document after presentation mode left, or when resizing the main window after presentation mode left.
      
      The diff selects the notifyViewportChanged way (align viewport top border with page top margin) as golden behavior in case of rePos.enabled == false.
      
      BUGS: 357958
      CCBUG: 341939
      CCBUG: 400890
      
      341939 and 400890 are fixed partially. These two still suffer from a minor displacement that happens when finished signal arrives from pixmap generation thread.
      
      Test Plan:
      - When using the footer page navigation to jump to different pages, new page top is always algined with viewport top.
      - After changing page with footer page navigation, press F5 to reload. Page top stays aligned with viewport top.
      - When exiting presentation mode, and touching the file, page top stays aligned with viewport top.
      - When exiting presentation mode, and changing main window size, page top stays aligned with viewport top.
      
      Reviewers: #okular, sander
      
      Reviewed By: sander
      
      Subscribers: ngraham, sander, aacid, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D16941
      a29e4eaf
  21. 14 Nov, 2018 1 commit
  22. 23 Oct, 2018 1 commit
    • Albert Astals Cid's avatar
      Add three autotests for part saving · 05462e26
      Albert Astals Cid authored
      * saving as on a non existing file works
      * saving as on a symlink doesn't destroy the symlink
      * saving on the symlink used to open the file doesn't destroy the
      symlink
      05462e26
  23. 13 Aug, 2018 1 commit
    • Ahmad Osama's avatar
      Fix problem of saving pdf switches from thumbnail view in sidebar to contents view · 5e622484
      Ahmad Osama authored
      Summary:
      When save/save as functions are called they internally call the openFile() function, in the open file function the side bar item is set to Table of Contents (ToC) item
      
      ```
      if ( m_document->metaData( QStringLiteral("OpenTOC") ).toBool() && m_sidebar->isItemEnabled( m_toc ) && !m_sidebar->isCollapsed() && m_sidebar->currentItem() != m_toc )
      {
           m_sidebar->setCurrentItem( m_toc, Sidebar::DoNotUncollapseIfCollapsed );
      }
      ```
      so I just store the sidebar's item before saving and then set this item back if changed.
      
      BUG: 389668
      
      Reviewers: #okular
      
      Subscribers: aacid, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D14740
      5e622484
  24. 08 Aug, 2018 1 commit
  25. 30 May, 2018 1 commit
    • Andre Heinecke's avatar
      Add test for additional form actions · 5103e8db
      Andre Heinecke authored
      Summary: This tests the newly added additional widget actions.
      
      Test Plan:
      Passes for me. Is my first GUI test, maybe the timing
      needs to be slower for slower machines?
      
      Reviewers: aacid
      
      Reviewed By: aacid
      
      Subscribers: okular-devel
      
      Tags: #okular
      
      Maniphest Tasks: T8627
      
      Differential Revision: https://phabricator.kde.org/D13170
      5103e8db
  26. 18 May, 2018 1 commit
  27. 22 Apr, 2018 1 commit
  28. 20 Mar, 2018 1 commit
  29. 25 Feb, 2018 4 commits
  30. 05 Feb, 2018 1 commit
  31. 31 Jan, 2018 1 commit