GitLab

Summary: BUG: 384147

Reviewers: rkflx

Reviewed By: rkflx

Subscribers: ngraham, rkflx, tobiasdeiminger, #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D7874

Summary:
The KPixmapSequence constructor needs the full path of the icon, so the
current code doesn't work and generates a "Invalid pixmap specified"
warning at runtime. By using KIconLoader we can fix this issue.

Test Plan: Search something and reach the end of document to make the animation start.

Subscribers: #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D7996

Summary:
BUG: 382139

Previously these labels were white-on-light-blue with light themes; now they use the correct theme color property, and become black appropriately.

Test Plan:
Tested on KDE Neon (dev unstable). Verified that with the default Breeze color scheme, tab text is more readable when hovered over and then active but not in focus. See before and after:

{F3909142}

{F3909143}

Also tested these changes with all standard color schemes as well as the Oxygen theme to make sure that there were no visual regressions.

Reviewers: aacid, #okular, #kde_applications, broulik, sander, rkflx

Reviewed By: aacid, #okular, #kde_applications, rkflx

Subscribers: rkflx

Tags: #okular

Differential Revision: https://phabricator.kde.org/D7793

Summary:
Files saved with QSaveFile don't get dirty. They are deleted and replaced.
Thus, inotify and KDirWatch don't emit a "dirty" signal (which is the correct behaviour).
Listening for the "created" signal of KDirWatch allows us to get notified on replaced files.

BUG: 384185

Test Plan:
Opened a markdown document in Okular.
Edited and saved the document with Kate.
The file is reloaded in Okular as expected.

Reviewers: aacid

Reviewed By: aacid

Subscribers: sander, rkflx, #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D7671

Summary: Makes it a bit more obvious that Kirigami is needed at runtime.

Test Plan: Shows a nice status message

Reviewers: #okular, aacid

Tags: #okular

Differential Revision: https://phabricator.kde.org/D7241

If you press and hold F5 we try to reload multiple times, which isn't a nice idea, let's finish one before starting the next

Unregister the part dbus object when it gets destroyed

Also fixes a crash if you try to inspect okular with qdbusviewer after having closed the a part/tab

BUGS: 384142

Generators are libraries, so define the proper TRANSLATION_DOMAIN
for each for them.

Thanks Albert for spotting this.

BUGS: 383734

Summary:
In >=KF-5.38 target kimgiotest is only built if BUILD_TESTING=ON,
so subsequent target_compile_definitions will fail if OFF.

Reviewers: #okular

Subscribers: kfunk

Tags: #okular

Differential Revision: https://phabricator.kde.org/D7212

upstream plucker is dead so no need to maitain code unchanged to ease merges
the variables were set but never used so for now commented them out

It is needed because EOLCnt is set inside a macro used from various functions but the EOLCnt value
is then not really used in all of the functions so for those that are not used creates a "set but not used warning"

May potentially cause a crash

port kirigami 1 usage to kirigami 2
partially port to QQC2 when possible
(will need to wait newer qt versions for a full port waiting on
icons on toolbuttons and the new ScrollView

REVIEW: 130172

The method FilePrinter::psPaperSize used to contain a long
list of hard-coded paper sizes for the different paper formats.
This patch makes the method get the same information
from QPrinter directly, which is much simpler and more
robust, too.

Note that the method is not actually used anywhere in okular,
though, so this change is purely cosmetic.

REVIEW: 130043

No need to sync it when Shell uses a native menubar

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"