1. 02 Nov, 2019 1 commit
  2. 27 May, 2019 1 commit
  3. 25 Sep, 2018 1 commit
    • Dileep Sankhla's avatar
      Add typewriter annotation tool · 6dd7cf66
      Dileep Sankhla authored and Tobias Deiminger's avatar Tobias Deiminger committed
      Summary:
      Typewriter is originally specified by the PDF reference as special FreeText annotation, where Intent=FreeTextTypewriter. It features opaque letters on transparent background, so that users can fill non interactive forms. Herewith typewriter is implemented natively for PDF, and there's also an Okular specific implementation for other document types. The added tool reuses the inline note UI.
      
      This work was done during GSoC 2018. See https://community.kde.org/GSoC/2018/StatusReports/DileepSankhla for details.
      
      FEATURE: 353401
      
      Test Plan:
      - okularpartrc is generated (if not yet existing) with typewriter as 10th tool
      - typewriter tool is also available in Annotation Tools -> Add, Typ "Typewriter"
      - selecting the tool and left click into document opens inline note input dialog
      - finishing creates an annotation similar to inline note, but with transparent background
      - saving into PDF results in /Subtype FreeText /IT /FreeTextTypeWriter
      - saving typewriter into archive stores color with alpha channel = 0x00
      - opening annotated archive works, if archive was created with old Okular, and opened in patched Okular
      - opening annotated archive works, if archive was created with patched Okular, and opened in old Okular
      
      Reviewers: sander
      
      Reviewed By: sander
      
      Subscribers: ngraham, sander, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D15204
      6dd7cf66
  4. 17 Aug, 2018 1 commit
  5. 18 May, 2018 1 commit
  6. 31 Jan, 2018 2 commits
    • Dileep Sankhla's avatar
      Use correct arrow cursor for Annotations' close buttons · 1e80804c
      Dileep Sankhla authored and Nate Graham's avatar Nate Graham committed
      Summary:
      When hovering the mouse over the X symbol to close a note the cursor remains the same of the current shape (hand, selection cursor) based on the tool selected.
      This patch morphe the cursor to the standard arrow over the X symbol to close a note by adding setCursor() call in the CloseButton constructor
      
       BUG: 384381
      
      Test Plan:
      1.  Open okular and select Tools -> Review or press F6 to create a new pop-up note
      2. Hover the mouse cursor over the close button (X) of the pop-up note window
      3. You will see the standard arrow instead of the current tool based cursor.
      
      Screenshot below (the tooltip saying "Close this note" was not captured by Spectacle application)
      {F5685539}
      
      Reviewers: #okular, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, #okular
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D10209
      1e80804c
    • Dileep Sankhla's avatar
      Use correct arrow cursor for Annotations' close buttons · de56b9c9
      Dileep Sankhla authored and Nate Graham's avatar Nate Graham committed
      Summary:
      When hovering the mouse over the X symbol to close a note the cursor remains the same of the current shape (hand, selection cursor) based on the tool selected.
      This patch morphe the cursor to the standard arrow over the X symbol to close a note by adding setCursor() call in the CloseButton constructor
      
       BUG: 384381
      
      Test Plan:
      1.  Open okular and select Tools -> Review or press F6 to create a new pop-up note
      2. Hover the mouse cursor over the close button (X) of the pop-up note window
      3. You will see the standard arrow instead of the current tool based cursor.
      
      Screenshot below (the tooltip saying "Close this note" was not captured by Spectacle application)
      {F5685539}
      
      Reviewers: #okular, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: ngraham, #okular
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D10209
      de56b9c9
  7. 16 Nov, 2017 1 commit
  8. 26 Oct, 2017 1 commit
    • Albert Astals Cid's avatar
      Implement swapBackingFile for the PDF backend · ca5422d0
      Albert Astals Cid authored and Albert Astals Cid's avatar Albert Astals Cid committed
      How does it work:
       * What it does is really closing and opening the file again through poppler
       * This means that things that are generated in "open" time like Page, Rects, Annotations, Forms need to be updated
      	* For Page what we do is swap the PagePrivate so that other classes that hold Page* don't break
      		* Since some parts of the PagePrivate can be reused, we move them in PagePrivate::adoptGeneratedContents
      	* For all the commands in the undo stack we need to update the annotations/forms it refers to, added a new function to do that
      	* The annotationmodel needs updating it's pointers
      	* The widgets for the forms are reused and their form* updated
      	* the widgets for the videos are recreased since videos don't really hold much content (you lose the playing status on save but i think that's acceptable)
      
      TODO: Make this work for .okular files
      TODO: For files with password we will need to reload the file, asking for the password again and thus losing the undo stack, warn the user
      TODO: autotests
      ca5422d0
  9. 25 Oct, 2017 1 commit
  10. 05 Sep, 2017 1 commit
  11. 29 Oct, 2016 2 commits
  12. 11 Jul, 2016 1 commit
  13. 30 Jan, 2016 1 commit
    • Aleix Pol Gonzalez's avatar
      Drop libkscreen dependency · f42a3bad
      Aleix Pol Gonzalez authored
      Drops the x11 fallback. We were falling back to QX11Extras that were in
      fact using QScreen internally.
      Also remove the QDesktopWidget fallbacks for the same reason.
      Drops some API for fetching the dpi and unifies it with ::realDpi(QWidget).
      
      Based on Sebas's patch.
      Reviewed by Albert.
      
      REVIEW: 126913
      f42a3bad
  14. 29 Oct, 2015 1 commit
  15. 18 Aug, 2015 1 commit
  16. 04 Mar, 2015 1 commit
  17. 29 Jan, 2015 1 commit
  18. 12 Oct, 2014 1 commit
  19. 08 Oct, 2014 1 commit
  20. 01 Oct, 2014 2 commits
  21. 26 Sep, 2014 1 commit
    • Albert Astals Cid's avatar
      Fix latex render in annotations · 93121820
      Albert Astals Cid authored
      We need
        disconnect(textEdit, SIGNAL(cursorPositionChanged()), this,SLOT(slotsaveWindowText()));
      and it's counterpart, otherwise when inserting the image, the cursor pos changes, slotsaveWindowText is called, the content is passed by a toPlainText and set again and kaboom the content is lost
      
      Also a few extra const
      
      BUGS: 335476
      FIXED-IN: 4.14.2
      93121820
  22. 16 Sep, 2014 1 commit
  23. 11 Sep, 2014 1 commit
  24. 09 Sep, 2014 1 commit
  25. 10 Aug, 2014 1 commit
  26. 08 Aug, 2014 1 commit
  27. 14 Oct, 2013 1 commit
  28. 05 Apr, 2013 1 commit
  29. 04 Jun, 2012 1 commit
  30. 17 May, 2012 2 commits
    • Fabio D'Urso's avatar
      Disable GUI operations on certain types of annotations · f6fa2a56
      Fabio D'Urso authored
      Modification and removal of *external* annotations are disabled by this
      patch. Note that this change doesn't remove any functionality, because they
      have never been implemented (AnnotationProxy is defined by the previous
      patch).
      
      The #if0'd blocks will be enabled by a future patch that provides fallback
      behavior for generators that don't support saving changes.
      f6fa2a56
    • Fabio D'Urso's avatar
      Added AnnotationProxy to SaveInterface · ec9f068d
      Fabio D'Urso authored
      Based on Pino Toscano's earlier work
      ec9f068d
  31. 17 Jan, 2012 1 commit
    • Albert Astals Cid's avatar
      Small rework of AnnotWindow · b2dfb910
      Albert Astals Cid authored
       * We do not keep them around any more time than needed (they are cheap to create)
       * AnnotWindow::slotsaveWindowText calls m_document->modifyPageAnnotation so
         edition of inline notes happens immediately
      b2dfb910
  32. 25 Nov, 2011 1 commit
  33. 24 Nov, 2011 1 commit
  34. 22 Sep, 2011 2 commits
  35. 31 Jul, 2011 1 commit