1. 21 Oct, 2019 1 commit
    • Harald Sitter's avatar
      don't crash on nullptr pdfOptionsPage · 568f11b0
      Harald Sitter authored
      same as in fbeff5ae there may not be
      a pdfOptionsPage when using print preview.
      this fixes an exciting crash on our windows build when trying to print
      Test Plan: can't easily build on windows but the traceback definitely falls over 0x0000 on that line, so given context I am confident this fixes the crash
      Reviewers: aacid
      Reviewed By: aacid
      Subscribers: okular-devel
      Tags: #okular
      Differential Revision: https://phabricator.kde.org/D24696
  2. 06 Oct, 2019 1 commit
  3. 04 Oct, 2019 1 commit
  4. 29 Sep, 2019 2 commits
  5. 25 Sep, 2019 1 commit
  6. 22 Sep, 2019 1 commit
  7. 09 Sep, 2019 1 commit
  8. 07 Sep, 2019 1 commit
  9. 06 Sep, 2019 1 commit
  10. 05 Sep, 2019 1 commit
  11. 03 Sep, 2019 1 commit
  12. 02 Sep, 2019 1 commit
  13. 01 Sep, 2019 2 commits
  14. 31 Aug, 2019 1 commit
  15. 30 Aug, 2019 1 commit
  16. 22 Aug, 2019 1 commit
  17. 12 Aug, 2019 1 commit
  18. 08 Aug, 2019 1 commit
  19. 07 Aug, 2019 1 commit
    • Andrey Yashkin's avatar
      Fix an incorrect text bounding rectangle calculation inside the sidebar · 5099b615
      Andrey Yashkin authored and Albert Astals Cid's avatar Albert Astals Cid committed
      Now //fontBoundaries// always has smaller width than //boundingRect// from
      void QPainter::drawText(const QRect &rectangle, int flags, const QString &text, QRect *boundingRect = nullptr)
      which is required to enclose the whole text. The difference is only several pixels, but sometimes it can cause visual problems. You can see the sidebar without and with this patch in Russian language with Noto Sans 10pt font on a picture below.
      Now the first and the last symbols are fully visible.
      Reviewers: #okular
      Subscribers: okular-devel
      Tags: #okular
      Differential Revision: https://phabricator.kde.org/D23012
  20. 31 Jul, 2019 1 commit
  21. 29 Jul, 2019 1 commit
  22. 17 Jul, 2019 8 commits
    • Albert Astals Cid's avatar
      Add linux testing CI · 327a6664
      Albert Astals Cid authored
    • Albert Astals Cid's avatar
      parttest: Move calculating the width/height to a bit later · a797d2ae
      Albert Astals Cid authored
      Seems to make tests more stable
    • Oliver Sander's avatar
      Fix page boundary gradients on scaled displays · 8e1d9aa4
      Oliver Sander authored and Albert Astals Cid's avatar Albert Astals Cid committed
      The code that draws a thin gradient at the right and bottom
      boundaries of a page implicitly assumed that the display was
      not scaled, i.e., that logical pixel where identical to
      physical pixels.  Nobody really noticed because that gradient
      was so thin.  Anyway, this patch fixes the gradient for
      scaled displays.
      I considered using a QLinearGradient, but decided against it:
      The code would have been longer, and the manual code in the
      patch can exploit the fact that all lines are horizontal
      or vertical.  Therefore, expensive scan-conversion can be
    • Oliver Sander's avatar
      Make the page outline one physical pixel wide · a0bd9c4d
      Oliver Sander authored and Albert Astals Cid's avatar Albert Astals Cid committed
      Pages get a black rectangle around them as 'outline' after
      being rendered.  This rendering was not pixel-perfect at
      fractional scalings: apparently, fractional line widths and
      positions get rounded differently.  The result was that
      sometimes there was a small gap between outline and page.
      This pages fixes the problem by making the pen for the
      outline 'cosmetic', i.e., one physical pixel wide.
      With that, its position can be such that it encloses
      the page without any gap.
    • Oliver Sander's avatar
      Make page boundary rendering more robust · 9b34bfb4
      Oliver Sander authored and Albert Astals Cid's avatar Albert Astals Cid committed
      Okular renders a simple 'shadow' at the right and the bottom of each
      page.  The code for this is a bit fragile:  After the page is rendered,
      Okular paints a black outline, and then the shadow.  The shadow is
      a hand-implemented gradient, painted line by line.  Finally, the
      remaining area is painted in the background color.  No pixel is
      ever touched twice.  Unfortunately, the code is buggy, and in hidpi /
      fractional scaling situations, some pixels are never touched.
      This results in rendering glitches as reported in
      Instead of trying to fix the previous approach, this patch makes the
      code more robust by changing the order of the painting operations.
      After painting the page, the code now first paints the background,
      which is now enlarged to cover everything off the page.  Finally,
      the black outline and shadow are drawn on the previously drawn
      background.  This makes sures that no pixel is ever left uninitialized.
      It also allows to simplify the shadow drawing operation a bit.
      BUG: 383943
    • Oliver Sander's avatar
      Use range-based for to iterate over a QRegion · f681fb0e
      Oliver Sander authored and Albert Astals Cid's avatar Albert Astals Cid committed
      According to
      the method QRegion::rects is obsolete and should be avoided.
      Let's do that by moving to a range-based for over the QRegion.
      That is easier to read anyway.
    • Yuri Chornoivan's avatar
    • Nate Graham's avatar
      Add "Open Containing Folder" feature · ea0ea9c9
      Nate Graham authored
      This patch adds an "Open Containing Folder" menu item to the file menu, similar to
      other KDE apps like Gwenview that have it there. This action is especially useful
      for the case when you've downloaded a PDF from the internet that opens itself in
      Okular. The location of this file may not be clear or easy to find without this
      feature, and on several occasiona I have found myself wishing for it when this
      Test Plan:
      - Delete or move aside `~/.local/config/kxmlgui5/okular/part.rc`
      - Menu item is enabled and works when there is an open document: {F6940449, size=full}
      - Menu item is disabled when there is no open document: {F6940448, size=full}
      Reviewers: #okular, aacid, sander
      Reviewed By: #okular, aacid
      Subscribers: shubham, davidhurka, okular-devel
      Tags: #okular
      Differential Revision: https://phabricator.kde.org/D22145
  23. 15 Jul, 2019 1 commit
  24. 14 Jul, 2019 2 commits
  25. 04 Jul, 2019 1 commit
  26. 03 Jul, 2019 5 commits