1. 19 Jun, 2021 1 commit
  2. 10 Jun, 2021 4 commits
  3. 29 May, 2021 1 commit
    • David Hurka's avatar
      Create color mode menu. · 195bbe36
      David Hurka authored
      Implemented using a ColorModeMenu class,
      derived from ToggleActionMenu (derived from KActionMenu),
      as a child object of PageView.
      
      * KToggleAction for every color mode, allows to set shortcuts for every mode.
        Color mode actions have icons.
      * KToggleAction for normal colors mode.
      * ToggleActionMenu containing all color mode actions.
        If triggered, toggles color mode between normal colors and last change colors mode.
      
      "Toggle Change Colors" is replaced by "Change Colors", which is actually a toggle action.
      
      BUG: 407217
      BUG: 437755
      195bbe36
  4. 18 May, 2021 1 commit
  5. 25 Apr, 2021 1 commit
  6. 23 Apr, 2021 1 commit
  7. 21 Apr, 2021 1 commit
  8. 20 Apr, 2021 1 commit
    • Gerd Wachsmuth's avatar
      Fix: Viewport coords normalized w.r.t. full page · 61551d23
      Gerd Wachsmuth authored
      The coordinates in Viewport.rePos are normalized on the full page. In
      two functions within pageview.cpp, these were treated as coordinates on
      the cropped page.
      
      CCBUG: 198427
      
      This partially fixes the bug 198427 in the case that the cropping of the
      target pages (and the pages around the target) is known at the time the
      link is clicked. That is, it works if
      
      - One uses 'Trim To Selection'
      - One uses 'Trim To Margin' and has already viewed at the target
      page(s).
      
      In the case that the cropping of the page at the target is unknown, we
      still end up at the wrong position.
      61551d23
  9. 11 Apr, 2021 2 commits
  10. 09 Apr, 2021 1 commit
  11. 08 Apr, 2021 1 commit
  12. 07 Apr, 2021 1 commit
    • Mahmoud Khalil's avatar
      Fixes changing continuous mode while on tabs issue · aa0d1b45
      Mahmoud Khalil authored and Albert Astals Cid's avatar Albert Astals Cid committed
      Toggling the Continuous mode while opening multiple tabs caused an issue
      in Okular, in which it considered it a global setting. So, toggling it
      for one document, then toggling it again for the other documents may not
      take effect. This should fix it by considering this setting a per
      document setting, and therefore toggling the mode for one document
      shouldn't have any effect for other documents.
      
      BUGS: 422080
      aa0d1b45
  13. 25 Mar, 2021 1 commit
  14. 07 Mar, 2021 1 commit
    • Oliver Sander's avatar
      Remove device pixel ratio scaling from PixmapRequest · ccda6d2a
      Oliver Sander authored and Albert Astals Cid's avatar Albert Astals Cid committed
      The PixmapRequest constructor expected width and height in logical
      pixels, and scaled them to device pixels.  However, not knowing what
      screen the request is for, it had to use qApp->devicePixelRatio()
      for the scaling.  That value may not be correct if not all screens
      use the same scaling.
      
      Fix this by introducing a new constructor that takes the device
      pixel ratio as an additional argument, and deprecating the old
      constructor.
      ccda6d2a
  15. 09 Feb, 2021 1 commit
  16. 25 Dec, 2020 1 commit
    • Steven Chua's avatar
      Fix Table Selection polluting clipboard history · 2917e739
      Steven Chua authored and David Hurka's avatar David Hurka committed
      The Table Select tool no longer automatically copies its
      contents to the clipboard, but only to the selection clipboard.
      (Middle-click paste clipboard.) Instead, after creating
      the table, the user can right-click to bring up a popup
      menu with the action "Copy Table Contents to the Clipboard".
      Clicking on this will copy the table contents to the clipboard.
      Ctrl+C also works.
      
      BUG: 402110
      2917e739
  17. 13 Dec, 2020 10 commits
  18. 09 Dec, 2020 1 commit
  19. 20 Nov, 2020 2 commits
    • David Hurka's avatar
      Fix QScroller crash on Qt < 5.14 and certain screen arrangements · c6a32751
      David Hurka authored
      QScrollerPrivate::setDpiFromWidget() before Qt 5.14 crashes
      when the target widget does not intersect a physical screen,
      because QDesktopWidget returns screen index `-1` in this case,
      which leads to an out-of-range read from QApplication::screens(),
      which leads to a segfault when reading from an invalid QScreen* pointer.
      
      This adds a workaround that checks for the `-1` situation,
      and then tries to resize PageView temporarily to intersect at least some screen.
      
      BUG: 425188
      FIXED-IN: 20.12
      c6a32751
    • Alex Rosca's avatar
      Avoid unintentional accelerating flicks by reducing maximum flick time · 8ae95b29
      Alex Rosca authored and David Hurka's avatar David Hurka committed
      When making a flick using the mouse or the touchscreen and then slowly
      dragging the pages in the same direction with the flick, it unintentionally
      reenters the flicking state after a mouse button release and it's quite
      annoying. The commit reduces the maximum time before the next flick.
      
      Steps to reproduce:
      1) Flick in direction A.
      2) While the view is coasting, decide that you want to stop close to the current position.
      3) Grab the view (still coasting), and drag it slowly in direction A.
      4) When you reached the desired point, stop your movement, and release the view.
      5) QScroller interprets this release as “accelerating flick”,
         and makes the view coast faster in direction A.
      
      Upstream bug is QTBUG-88249; QScroller ignores MinimumVelocity for accelerating flicks.
      8ae95b29
  20. 18 Nov, 2020 1 commit
    • David Hurka's avatar
      New part/ directory for okularpart sources from /, ui/, conf/ · 19d5dd8e
      David Hurka authored
      Source files are no longer separated by UI and non-UI and similar,
      but only by their build target.
      
      * ui/ -> part/
      * Move all source files from conf/ to part/
      * Keep config skeleton definitions in conf/, needed for the mobile target too
      * Move editdrawingtooldialogtest.h from conf/autotests/ to autotests/
      * ui/data/icons/ -> icons/
      * Move /part.cpp, /part.rc and similar files to part/
      * Adapt include paths in source files
      * Adapt CMakeLists.txt files (in / and in subdirectories)
      * Adapt /Messages.sh
      19d5dd8e
  21. 14 Nov, 2020 1 commit
    • Alexander Lohnau's avatar
      Remove dead code · 3c1fa441
      Alexander Lohnau authored
      A lot of this code has been commented out for over
      a decade and adds no value to the project.
      It is only annoying when you look over it ;).
      
      Same for the KNS2 support which was commented out.
      
      Also some of the debug statements didn't even build
      anymore, because the properties got removed/refactored.
      3c1fa441
  22. 03 Nov, 2020 1 commit
  23. 01 Nov, 2020 1 commit
  24. 23 Oct, 2020 1 commit
  25. 21 Oct, 2020 2 commits
    • Nate Graham's avatar
      Fix fast scrolling with Shift+Scroll · 777ac37e
      Nate Graham authored
      When holding down the shift key, multiply wheel and touchpad scroll
      distances by 10 to re-implement the fast scrolling feature that
      broke when we added animated/smooth scrolling.
      
      BUG: 420889
      FIXED-IN: 1.11.3
      777ac37e
    • David Hurka's avatar
      Fix cursor not updated after clicking internal link · 843c43cc
      David Hurka authored and Nate Graham's avatar Nate Graham committed
      updateCursor() was called by wheelEvent(), which made sense,
      because after the wheel event the page will have moved under the cursor.
      
      With smooth scrolling, it makes less sense in wheelEvent(),
      because at that point scrolling is still in the future.
      
      scrollContentsBy() appears to be called on every scroll step.
      (It is documented to be called at scrollbar value changes, so makes sense.)
      
      This patch removes updateCursor() from wheelEvent(), but adds it to scrollContentsBy().
      
      I did not check anything out with d->visibleItems, as was indicated it !176.
      
      BUG: 421437
      843c43cc