1. 15 May, 2020 1 commit
  2. 29 Apr, 2020 1 commit
  3. 25 Apr, 2020 1 commit
  4. 15 Mar, 2020 1 commit
  5. 12 Mar, 2020 1 commit
    • David Hurka's avatar
      Move Continuous option to View Mode submenu · 493ba07e
      David Hurka authored
      Summary:
      This moves the Continuous option from the View menu to the
      View Mode submenu. This makes the View Mode menu (a KActionMenu)
      more useful in the main toolbar. Additionally, “Continuous” is explained by the context “View Mode”.
      
      The primary intention was to give this View Mode a similar usage pattern like
      the Change Colors menu (D21195), if both are added to the toolbar. See my
      suggestion in Bugs 407217 and 407326.
      
      FEATURE: 407326
      
      Screenshot before:
      {F6821917}
      
      Screenshot now:
      {F6821920}
      and in the toolbar:
      {F6821921}
      
      Test Plan:
      * Look into View menu and test entries
      * Add View Mode menu to toolbar and test entries
      
      Reviewers: #okular, #vdg, aacid
      
      Spies: aacid, ngraham, okular-devel, kde-doc-english
      
      Tags: #okular, #documentation
      
      Differential Revision: https://phabricator.kde.org/D21196
      493ba07e
  6. 08 Mar, 2020 2 commits
  7. 21 Feb, 2020 2 commits
  8. 20 Feb, 2020 3 commits
  9. 19 Feb, 2020 3 commits
  10. 09 Feb, 2020 1 commit
  11. 02 Feb, 2020 1 commit
    • David Hurka's avatar
      Replace ToolAction by ToggleActionMenu · c6d937ab
      David Hurka authored
      Summary:
      This replaces ToolAction by a near-drop-in replacement named ToggleActionMenu. The new annotation toolbar already uses this (D15580).
      
      Unlike ToolAction, ToggleActionMenu inherits from KActionMenu to be more flexible.
      * Menu can be set from outside, not hard coded.
      * Default action for toolbar button is controllable from outside. (Theoretically, the button could trigger //anything// now.)
      * KActionMenu instead of KSelectAction:
        - Pluggable in other menus, thus called “Menu”.
        - Doesn’t make the actions exclusive, so //any// actions can be added to the menu.
      * ImplicitDefaultAction mode can choose the default action of the toolbar buttons automatically, by looking for the first checked action in the menu.
      
      Toolbar buttons use the default action //of// this menu, not this menu itself as action.
      
      Because the default action is configurable now, D21622 and D21635 (where we tried to fine-tune ToolAction) become obsolete.
      
      Screenshot:
      Everything like before, here with mouse_selecttool added to Tools menu to show submenu capability.
      {F6884228}
      
      Test Plan:
      ToolAction replacement and ImplicitDefaultAction mode:
       * Open Okular and look at toolbar button -> has correct tool selected.
       * Open a document.
       * Look at toolbar button menu -> Correct menu entries (like before, with ToolAction).
       * Select some selection tools through shortcuts and toolbar button -> behaves correctly.
      Usage as submenu:
       * Add ToggleActionMenu ("mouse_selecttool") to menubar (..../kxmlgui5/okular/part.rc) -> Submenu looks correctly, has no checkbox attached and so on...
      Toolbar buttons:
       * Add diverse other actions to the menu -> still works as before.
       * Add actions when toolbar buttons are already created -> actions are added to existing buttons.
       * setDefaultAction() to some completely unrelated action. -> ToggleActionMenu does not get confused.
      
      Reviewers: simgunz
      
      Reviewed By: simgunz
      
      Subscribers: aacid, ngraham, simgunz, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D21971
      c6d937ab
  12. 11 Jan, 2020 1 commit
  13. 07 Jan, 2020 1 commit
    • Albert Astals Cid's avatar
      "Fix" PartTest::testAdditionalActionTriggers · 45303be6
      Albert Astals Cid authored
      By waiting for the delayResizeEventTimer to trigger before starting the
      test.
      
      The test "randomly" failed before, which shows there's an actual bug in
      the code, but the actual bug is "if you are moving the mouse over a
      field that has a on focus action and at that very same time the
      delayResizeEventTimer triggers, the action won't be executed".
      
      That's almost impossible to reproduce in real life so i'm going to
      pretend the bug is not there for all purposes
      45303be6
  14. 28 Dec, 2019 1 commit
  15. 24 Dec, 2019 1 commit
  16. 23 Dec, 2019 1 commit
  17. 20 Dec, 2019 2 commits
  18. 09 Dec, 2019 1 commit
  19. 26 Nov, 2019 1 commit
  20. 15 Nov, 2019 1 commit
    • kezi olio's avatar
      Add kinetic scrolling & smooth navigation with cursor keys · 51b90ecd
      kezi olio authored
      This patch adds kinetic / inertial scrolling to ease the use of Okular on touchscreen devices, using Qt's QScroller. I think it's much nicer even for mouse usage.
      
      I left the "mouse cursor wraps when going at the edge of the screen" mechanism intact.
      
      Also, I made it so that there is a nice animation when using the up / down keys to navigate the document, instead of having discrete steps.
      
      FEATURE: 413989
      
      FIXED-IN: 1.10.0
      51b90ecd
  21. 09 Oct, 2019 2 commits
  22. 08 Oct, 2019 1 commit
  23. 05 Oct, 2019 1 commit
  24. 02 Oct, 2019 3 commits
    • Oliver Sander's avatar
      Fix return value of PageView::capabilityFlags · 8839ea10
      Oliver Sander authored
      The return type of that method is Okular::View::CapabilityFlags.
      Hence, returning 'nullptr' as was done previously cannot be correct,
      and 'NoFlag' should be used instead.  As both evaluate to '0'
      internally there should not be any functional difference.
      8839ea10
    • Oliver Sander's avatar
      Simplify a loop · 425a6aa4
      Oliver Sander authored
      425a6aa4
    • Felix Mauch's avatar
      Save view information per file · bd25d17e
      Felix Mauch authored
      Adds the functionality to save the view mode (single page, facing...),
      continuous scrolling, and margin trimming  to the document information,
      as it is already done with the zoom information.
      bd25d17e
  25. 22 Sep, 2019 1 commit
  26. 21 Sep, 2019 1 commit
  27. 18 Sep, 2019 1 commit
  28. 22 Aug, 2019 2 commits
  29. 11 Aug, 2019 1 commit