GitLab

The text generator is the only one compiled now.
This version links for me but then doesn't find its KPart on startup.

TTS has been completely disabled as well as some other things like the
about dialog.

While it's generally not a great idea to include moc files at least this
compiles.

If a "fast" sequence of signals is sent to the part, the hiding
animation could lead to a broken resize (as it the new message
is handled during the resize). Remove the animation for now.

Less widgets in generators/core \o/

Those two categories are usually longer messages and more
important, so more fit for a (new) KMessageWidget; simple
notice signals still go to PageViewMessage into PageView.

A more general review of all the messages should be probably
performed in order to assign proper categories to them.

Reviewed by: Albert Astal Cid

This helps with the widget dependency removal in the core/backends

Acked by Albert Astal Cid

Opened a file with all pages with same size and behaves exactly like Okular does
Opened a file with pages with different sizes and behaves like Okular does until it stops fiting. In that moment the page bar is not centered anymore to let the text still fit and once the text doesn't fit anymore it starts getting ellided.

Reviewed by Luigi

BUGS: 333349
FIXED-IN: 4.13.1

Make the receivers be the ones that check for empty, not the senders

Jonathan Doman authored Apr 09, 2014 and Albert Astals Cid committed Apr 09, 2014

FIXED-IN: 4.13.0
BUGS: 331872
BUGS: 332238
REVIEW: 116700

In an ideal world I would have commented this in reviewboard and Saheb would
have fixed it, but Feature Freeze is almost here so I decided just to fix it myself

Saheb Preet Singh authored Feb 24, 2014 and Albert Astals Cid committed Feb 24, 2014

REVIEW: 115072
BUGS: 328125
GUI

Michal Humpula authored Feb 19, 2014 and Albert Astals Cid committed Feb 19, 2014

It's straighforward implementation. Every single place, where there were call for (or with) TilesManager, now has a DocumentObserver as companion. The m_tiledManager reference in PagePrivate was changed to QMap<DocumentObserver, TilesManager>.

REVIEW: 113986

Also make it non enabled by default for now

GUI
BUGS: 155515

Jonathan Doman authored Feb 08, 2014 and Albert Astals Cid committed Feb 08, 2014

GUI
BUGS: 155515
REVIEW: 110914

BUG: 329863

BUG: 329863

Mailson Menezes authored Dec 29, 2013 and Albert Astals Cid committed Dec 29, 2013

Fix adding and removing bookmarks in the thumbnail panel

Add and removal of bookmarks via the thumbnail context menu was acting
on the current viewport instead of the clicked page. This patch checks
whether it should act on the viewport or in the right clicked page.

BUGS: 323267
FIXED-IN: 4.11.5

BUGS: 327203
FIXED-IN: 4.12.1

BUGS: 327641
FIXED-IN: 4.11.95

Stefan Radermacher authored Sep 27, 2013 and Fabio D'Urso committed Sep 30, 2013

FEATURE: 321169
FIXED-IN: 4.12.0
REVIEW: 111036

And not any other file in the folder
BUGS: 321880
FIXED-IN: 4.11.0

So that next time slotDoFileDirty() is called, it will save data again, instead
of keeping data from the old reload attempt.

This would have caught the issue fixed in 3dd3a000

Because a cached dialog stays parented to the initial part, which might
not be the one used to open it.
This is especially visible now that we support more than one window per
okular process.

For example:
 - User initially opens a dialog from window A
      -> This dialog gets cached as child of A's PageView. This implies that
         clicking on the dialog also brings window A to foreground.
 - User re-opens the dialog from a different window B
      -> The dialog is still a child of A's PageView, therefore clicking on the
         dialog's frame brings A to the foreground, and B to the background.

Instead of listening on KConfigDialog's signals, this patch makes parts
listen on Okular::Settings::self()'s configChanged() signal.

Unlike KConfigDialogs, Okular::Settings::self() is unique and never
changes during the process lifetime, and therefore:
 - A part can connect during initialization and receive notifications,
   without depeding on KConfigDialog objects (which might be instanced
   or deleted by a different part).
 - The connection now survives deletion of the KConfigDialog.

Instead of using a hardcoded map
BUGS: 320195
FIXED-IN: 4.10.4

Instead of using a hardcoded map
BUGS: 320195
FIXED-IN: 4.10.4

BUG: 319042
FIXED-IN: 4.11.0
REVIEW: 110419

Tomáš Poledný authored Mar 11, 2013 and Albert Astals Cid committed Mar 11, 2013

BUGS: 252462
REVIEW: 109096
FIXED-IN: 4.11.0
GUI

Just use the pointer as id :-)

This is BIC and SIC, increase the soversion now to makes sure we don't forget in the future

Patch based in an earlier patch by Bogdan Cristea <cristeab@gmail.com>
REVIEW: 109115