1. 11 Oct, 2020 1 commit
    • Tobias Deiminger's avatar
      Complete TextSelectorEngine if nothing selected · c8cf6513
      Tobias Deiminger authored
      Selecting highlight tool, pressing left mouse button while over text, and
      immediately releasing without dragging a selection caused inconsistent state.
      
      It left TextSelectorEnigne in the state m_creationCompleted == false and
      m_lockedItem == something. Then in continuous mode all events kept on being
      propagated to TextSelectorEngine::event, even if the user started unrelated
      interactions in the meantime. This caused various side effects.
      
      It notably happened when you double clicked a finished highlight annotation,
      as described in bug 426658.
      
      We can go to m_creationComplete after release even without a selection,
      because TextSelectorEngine::end and PageViewAnnotator::performRouteMouseOrTabletEvent
      handle the case just fine, i.e. don't create an annotation but reset the state machine.
      
      Fixes bug 426658 at least partially. I couldn't reproduce the described crash,
      so no idea if that's also fixed.
      
      BUG: 446658
      c8cf6513
  2. 05 Oct, 2020 1 commit
  3. 03 Oct, 2020 2 commits
  4. 30 Sep, 2020 1 commit
  5. 29 Sep, 2020 1 commit
  6. 25 Sep, 2020 2 commits
    • Kezi Olio's avatar
      Fix forms when inertially scrolling · bdb2df77
      Kezi Olio authored
      `setViewport` automatically adds an item to the history if it finds that it
      moved for more than a page, which we don't want to do when automatically
      scrolling, as with inertial scrolling.
      
      This commit adds a new function `setViewportWithHistory()` which takes an
      argument to optionally avoid preserving history. This avoids breaking ABI.
      The new history-less functionality is used when inertially scrolling.
      
      BUG: 421354
      FIXED-IN: 1.11.2
      bdb2df77
    • Script Kiddy's avatar
      SVN_SILENT made messages (.desktop file) - always resolve ours · 601e9603
      Script Kiddy authored
      In case of conflict in i18n, keep the version of the branch "ours"
      To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
      601e9603
  7. 21 Sep, 2020 3 commits
  8. 20 Sep, 2020 1 commit
  9. 16 Sep, 2020 2 commits
  10. 15 Sep, 2020 1 commit
  11. 11 Sep, 2020 2 commits
  12. 06 Sep, 2020 1 commit
  13. 31 Aug, 2020 3 commits
  14. 30 Aug, 2020 1 commit
  15. 25 Aug, 2020 1 commit
    • Simone Gaiarin's avatar
      Store the state of the builtin annotations in a new config key · 10d92fbe
      Simone Gaiarin authored
      Using the new configuration key BuiltinAnnotationTools instead of AnnotationTools, we avoid any conflicts in the configuration files due to the fact that the key AnnotationTools had a different meaning in the previous versions of Okular. In particular we avoid the critical problem that the actions in the UI do not match the actual annotation tools. The conflict may happen if the kconf_update script is not executed for some reason (e.g. okular running from flatpack).
      
      BUG: 425354
      FIXED-IN: 1.11.1
      10d92fbe
  16. 07 Aug, 2020 2 commits
  17. 06 Aug, 2020 1 commit
    • David Hurka's avatar
      PresentationWidget: Fix screen switching at runtime · 2c70ec41
      David Hurka authored
      Screen switching from inside presentation mode currently does not work correctly.
      The reason is that the widget geometry() shall be moved
      *while* the widget is configured as fullscreen.
      This patch temporarily disables fullscreen, so the screen can be switched.
      
      You can check it with release 20.04:
      Screen switching from within presentation mode will not work.
      Set the widget to windowed (e. g. Alt+F3 or right-click in task manager),
      screen switching will work now.
      
      !233 shall port PresentationWidget to QScreen in release 20.12,
      so this is just a compact workaround without much intelligence.
      The drawback is that custom window rules might get confused when the
      screen geometry changes for some reasons.
      2c70ec41
  18. 05 Aug, 2020 2 commits
    • Simone Gaiarin's avatar
      Find built-in tool corresponding to quick tool at runtime · 72f5a2db
      Simone Gaiarin authored
      In this way it is possible to drop the `sourceId` attribute from the quick tools definition. This simplifies the code logic and makes it easier to update user settings from the previous version of Okular (because there is no need to add the attribute `sourceId`
      
      This also fixes the crash due to the fact that `sourceId` was not correctly created when a quick annotation is created from the Annotation page of Okualr Settings.
      
      BUG: 424810
      FIXED-IN: 1.11.0
      72f5a2db
    • Christoph Feck's avatar
      f6ce4a57
  19. 04 Aug, 2020 1 commit
  20. 31 Jul, 2020 1 commit
  21. 30 Jul, 2020 2 commits
  22. 28 Jul, 2020 1 commit
  23. 23 Jul, 2020 5 commits
  24. 17 Jul, 2020 2 commits