1. 30 Sep, 2020 1 commit
  2. 20 Sep, 2020 1 commit
  3. 13 Sep, 2020 1 commit
  4. 10 Sep, 2020 1 commit
  5. 09 Sep, 2020 1 commit
    • Albert Astals Cid's avatar
      Revert cbddcd32 · 26971054
      Albert Astals Cid authored
      KJS and KWallet are indeed optional, that's what the ${optionalComponents} variable does
      26971054
  6. 06 Sep, 2020 1 commit
  7. 05 Sep, 2020 2 commits
  8. 14 Jul, 2020 1 commit
  9. 13 Jul, 2020 1 commit
  10. 12 Jul, 2020 1 commit
  11. 11 Jul, 2020 1 commit
    • Albert Astals Cid's avatar
      Run clang-format · 19d98d6a
      Albert Astals Cid authored
      find . \( -name "*.cpp" -or -name "*.h"  -or -name "*.c"  -or -name "*.cc" \) -exec clang-format -i {} \;
      
      If you reached this file doing a git blame, please see README.clang-format (added 2 commits in the future of this one)
      19d98d6a
  12. 04 Jun, 2020 1 commit
    • Simone Gaiarin's avatar
      Overhaul annotations UX · 0b05d7ce
      Simone Gaiarin authored
      Create a new new annotation toolbar to replace the current one as discussed in the task T8076.
      Fixes:
      BUG: 386578
      BUG: 374728
      BUG: 352310
      BUG: 330518
      BUG: 341914
      BUG: 157289
      BUG: 358057
      BUG: 412767
      BUG: 413595
      BUG: 420462
      FIXED-IN: 1.11.0
      
      Test Plan
      Before testing this revision
      Delete or Temporary move aside the following files:
      
      ~/.config/okularpartrc
      ~/.config/okularrc
      ~/.local/share/kxmlgui5/okular/part.rc
      ~/.local/share/kxmlgui5/okular/shell.rc
      
      Nomenclature
      Actions in the main toolbar:
      
      Quick annotations
      Actions in the annotation toolbar:
      
      Annotation actions Highlighter, Underline, Squiggle, Strike out, Typewriter,
      Inline note, Popup note, Freehand line, Arrow, Straight line, Rectangle, Ellipse,
      Polygon, Stamp
      
      Annotation config actions Line width, Color, Inner color, Opacity, Font, Annotation settings
      
      Other actions Add to Quick Annotations, Pin
      
      Autotests
      
       First run: annotation toolbar is not visible
      
       Selecting Tools > Annotations shows the annotation toolbar (below the ma...
      0b05d7ce
  13. 03 Jun, 2020 2 commits
  14. 02 Jun, 2020 1 commit
    • Albert Astals Cid's avatar
      Initialize m_tocEnabled · 3e6028c0
      Albert Astals Cid authored
      Othewise we get an unitialized memory use
      
      ==38984== Conditional jump or move depends on uninitialised value(s)
      ==38984==    at 0xE5B0125: Okular::Part::slotNewConfig() (part.cpp:3000)
      ==38984==    by 0xE59FAF1: Okular::Part::Part(QWidget*, QObject*, QList<QVariant> const&) (part.cpp:595)
      ==38984==    by 0xE5BB596: QObject* KPluginFactory::createPartInstance<Okular::Part>(QWidget*, QObject*, QList<QVariant> const&) (kpluginfactory.h:526)
      ==38984==    by 0x5401674: KPluginFactory::create(char const*, QWidget*, QObject*, QList<QVariant> const&, QString const&) (in /usr/lib/libKF5CoreAddons.so.5.70.0)
      ==38984==    by 0x124543: KParts::ReadWritePart* KPluginFactory::create<KParts::ReadWritePart>(QObject*, QList<QVariant> const&) (kpluginfactory.h:545)
      ==38984==    by 0x11D126: Shell::Shell(QString const&) (shell.cpp:97)
      ==38984==    by 0x11B250: Okular::main(QStringList const&, QString const&) (okular_main.cpp:169)
      ==38984==    by 0x118418: main (main.cpp:82)
      3e6028c0
  15. 27 May, 2020 1 commit
    • Nate Graham's avatar
      Improve the sidebar's navigation and UX · b8b36ae5
      Nate Graham authored
      Okular's sidebar vertical view chooser toolbar suffers from a few issues:
      
      * It's a nonstandard UI not used for category choosers in other pieces of KDE software,
        and not used in other FOSS document readers
      * What is shown and what is hidden is simultaneously too configurable while still not
        offering the desirable UI common to other programs (i.e. no visible category chooser,
        but a sidebar capable of displaying thumbnails, table of contents, search results, etc.)
      * With labels on it takes up quite a bit of horizontal space, while with labels off, the
        categories are less than clear
      * UX is kind of clunky with nonstandard behaviors (e.g. clicking on the current category
        to hide that category's view while keeping the view chooser visible, showing mostly
        disabled items)
      * It's made with custom painting code, which reduces maintainability and introduces bugs
        (e.g. https://bugs.kde.org/show_bug.cgi?id=408190)
      
      This patch removes the vertical category chooser entirely and replaces it with a tabbed
      view on the top of the sidebar itself. The tabs are icons-only and have large icons. A
      button is added on the left side of the default toolbar to quickly hide or show the
      sidebar. In order to make room for the new button, the Previous and Next buttons on the
      toolbar are removed, as previous/next buttons are already present on the Page Bar on the
      bottom of the window so there's no need to duplicate this functionality. This improves
      the UX, fixes a variety of bugs, and deletes a lot of custom code of dubious long-term
      maintainability.
      
      ![vokoscreenNG-2020-04-16_13-29-24](https://invent.kde.org/graphics/okular/uploads/a1f96a315b69282df51de9993b1befaf/vokoscreenNG-2020-04-16_13-29-24.webm)
      
      BUG: 213508
      
      BUG: 334441
      
      BUG: 344599
      
      BUG: 408190
      
      CCBUG: 335189
      
      FIXED-IN: 1.11.0
      
      CHANGELOG: The sidebar can now be easily shown or hidden with a toolbar button, and the category chooser no longer takes up so much space
      b8b36ae5
  16. 24 May, 2020 1 commit
    • Albert Astals Cid's avatar
      Remove the "Page Sizes" action from the menu · 0ada1973
      Albert Astals Cid authored
      It's only enabled when the document supports multiple page sizes, that
      at the time of writing (and since 13 years) is none
      
      So not great to have an always disabled menu :D
      
      The backend part (Document::supportsPageSizes) is still there, so if we
      ever reintroduce a backend that supports it part of the code is there,
      and probably we may want to rethink the UI so it only shows when useful,
      and not being disabled without possibility of enabling it for say PDF
      0ada1973
  17. 16 May, 2020 1 commit
    • Arshad Husain's avatar
      Do not show dialog when reloading file that requests fullscreen · 08a76add
      Arshad Husain authored
      When using Okular as previewer in PDFTex workflow, preparing beamer slides,
      the following usability hell occurred:
      
      * LaTex/Beamer slides should be compiled to PDF with metadata "StartFullScreen"
      * But while editing, on every PDF change/and reload, the user gets a modal popup
        "The document requested to be launched in presentation mode." "Do you want to allow it?"
      
      BUG: 361740
      08a76add
  18. 23 Apr, 2020 1 commit
  19. 21 Feb, 2020 2 commits
  20. 20 Feb, 2020 1 commit
  21. 19 Feb, 2020 1 commit
  22. 10 Feb, 2020 1 commit
  23. 23 Dec, 2019 1 commit
  24. 12 Dec, 2019 1 commit
  25. 17 Nov, 2019 1 commit
  26. 15 Nov, 2019 1 commit
    • kezi olio's avatar
      Add kinetic scrolling & smooth navigation with cursor keys · 51b90ecd
      kezi olio authored
      This patch adds kinetic / inertial scrolling to ease the use of Okular on touchscreen devices, using Qt's QScroller. I think it's much nicer even for mouse usage.
      
      I left the "mouse cursor wraps when going at the edge of the screen" mechanism intact.
      
      Also, I made it so that there is a nice animation when using the up / down keys to navigate the document, instead of having discrete steps.
      
      FEATURE: 413989
      
      FIXED-IN: 1.10.0
      51b90ecd
  27. 22 Sep, 2019 1 commit
  28. 18 Sep, 2019 1 commit
  29. 17 Jul, 2019 1 commit
    • Nate Graham's avatar
      Add "Open Containing Folder" feature · ea0ea9c9
      Nate Graham authored
      Summary:
      This patch adds an "Open Containing Folder" menu item to the file menu, similar to
      other KDE apps like Gwenview that have it there. This action is especially useful
      for the case when you've downloaded a PDF from the internet that opens itself in
      Okular. The location of this file may not be clear or easy to find without this
      feature, and on several occasiona I have found myself wishing for it when this
      happens.
      
      Test Plan:
      - Delete or move aside `~/.local/config/kxmlgui5/okular/part.rc`
      - Menu item is enabled and works when there is an open document: {F6940449, size=full}
      - Menu item is disabled when there is no open document: {F6940448, size=full}
      
      Reviewers: #okular, aacid, sander
      
      Reviewed By: #okular, aacid
      
      Subscribers: shubham, davidhurka, okular-devel
      
      Tags: #okular
      
      Differential Revision: https://phabricator.kde.org/D22145
      ea0ea9c9
  30. 27 May, 2019 1 commit
  31. 21 Apr, 2019 1 commit
    • Shubham  .'s avatar
      Add action in Edit menu to select the text on current page · f788b5a3
      Shubham . authored
      BUG: 358868
      
      Test Plan: Click on "Select All Text on Current Page" entry in Edit menu to select the entire page. The selected text can then be copied via Edit menu item "Copy"
      
      Reviewers: aacid, #vdg, ngraham
      
      Reviewed By: #vdg, ngraham
      
      Subscribers: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel
      
      Tags: #okular, #documentation
      
      Differential Revision: https://phabricator.kde.org/D18744
      f788b5a3
  32. 03 Apr, 2019 1 commit
    • Michael Weghorn's avatar
      Add option to ignore print margins for non-PDF generators · 8bf1a911
      Michael Weghorn authored
      Summary:
      This adds a combobox in the print dialog of the non-PDF
      generators to allow selecting whether or not to take
      print margins into account.
      
      For the PDF case and rasterized printing, new print otions have
      been implemented in commit 2e97d587
      already, which adds an additional option to do no scaling at all.
      
      For consistency reasons, the same terms also used for the PDF
      case are used in the combobox (i.e. the two of the three that
      apply).
      
      This adds a new abstract class 'PrintOptionsWidget' with a
      'ignorePrintMargins()' method to indicate whether print margins
      should be ignored or not, and a default implementation.
      The existing widget for the PDF generator now derives from this
      class.
      
      In order to avoid an ABI breakage, the return value of
      'Document::printConfigurationWidget' is left as a 'QWidget *'
      and a dynamic_cast is done on use.
      
      FilePrinter is adapted to take into account the value set by
      'QPrinter::setFull...
      8bf1a911
  33. 12 Mar, 2019 1 commit
  34. 13 Feb, 2019 1 commit
  35. 10 Jan, 2019 1 commit
    • Chinmoy Ranjan Pradhan's avatar
      Implement digital signature support for PDF · a234a902
      Chinmoy Ranjan Pradhan authored
      This is a squash of the original branch
      
      It also contains fixes/rework from Albert Astals Cid
      
      If you're interested in its history have a look at the
      gsoc2018_digitalsignature branch
      
      The poppler dependency situation is:
       * With 0.51 you get most signature information
       * With 0.68 you also get signature location/reason information
       * With 0.73 you also get signature certificate information
      a234a902
  36. 04 Jan, 2019 1 commit
  37. 21 Dec, 2018 1 commit