Follow-up from "Port config dialogs from .ui to QFormLayout"
These are remaining TODOs from !202 (merged):
General page
(before/after, resized vertically to show everything)
-
Collapse document title and background color checkboxes into the following control?
Accessibility page
-
This looks great! I have only a few UI comments for future improvement:
The Accessibility Reading Aids page looks a bit off, with too much whitespace above the text to speexh section, and no left labels for some checkboxes.
I would do it more like this:
General: [x] Draw border around links Colors: [ combobox with options, plus a "No modifications" entry] Text-to-speech engine: [ combobox with options ]And when you change the colors combobox to show anything other than "No modifications" a KMessageWidget would appear warning you of the potential performance consequences. No need to always show a warning; it can be contextual.
Presentation page
(before/after, resized vertically to show everything)
-
Reorder to group navigation settings? That should make the layout quieter, I think. -
For the Presentation page, I would re-do the first control group to be a bit more like this:
Advance: [x] Automatically every [ 5 seconds ] -
For transitions, I would do the same thing as for Colors, simply adding a new "None" entry into the combobox rather than having a separate checkbox to turn the feature on and off.