Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit 21f2c910 authored by Albert Astals Cid's avatar Albert Astals Cid

Fix crash when changing pages fast on presentation mode

The crash would happen because we were setting partial updates to true on requests
that were synchronous, because that sync request was cancelling an async one (prerender)
so now we only set newRequest partial updates to true when cancellingm another one if it's asynchronous

And a sync but with partial updates request would make stuff crash because the request
would all be processed on the main thread but generator_pdf.cpp cakks signalPartialPixmapRequest
with a queued connection so we that function was called the request would have already gone
parent 7e1832c5
......@@ -3208,7 +3208,7 @@ bool DocumentPrivate::cancelRenderingBecauseOf( PixmapRequest *executingRequest,
if ( !executingRequest->d->mResultImage.isNull() )
return false;
if ( newRequest && executingRequest->partialUpdatesWanted() ) {
if ( newRequest && newRequest->asynchronous() && executingRequest->partialUpdatesWanted() ) {
newRequest->setPartialUpdatesWanted( true );
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment