Commit 4d75045c authored by Yuri Chornoivan's avatar Yuri Chornoivan
Browse files

Fix minor EBN issues

parent 3d691577
Pipeline #17787 passed with stage
......@@ -294,12 +294,12 @@ void SearchTest::testHyphenAtEndOfLineWithoutYOverlap()
QCOMPARE(*result, expected);
delete result;
// If the user is looking for the text explicitely with the hyphen also find it
// If the user is looking for the text explicitly with the hyphen also find it
result = tp->findText(0, QStringLiteral("super-cali-fragilistic"), Okular::FromTop, Qt::CaseSensitive, nullptr);
QVERIFY(result);
delete result;
// If the user is looking for the text explicitely with the hyphen also find it
// If the user is looking for the text explicitly with the hyphen also find it
result = tp->findText(0, QStringLiteral("super-cali-fragilistic"), Okular::FromBottom, Qt::CaseSensitive, nullptr);
QVERIFY(result);
delete result;
......
......@@ -431,7 +431,7 @@ class OKULARCORE_EXPORT FormFieldChoice : public FormField
/**
* The possible choices of the choice field.
* The key is the the display name of the choice,
* The key is the display name of the choice,
* The value is the export value (i.e. for use in javascript, etc) of the choice
*
* @since 1.11
......
......@@ -41,7 +41,7 @@ class Scripter
friend class ScripterPrivate;
ScripterPrivate* d;
Scripter( DocumentPrivate *doc );
explicit Scripter( DocumentPrivate *doc );
};
}
......
......@@ -131,7 +131,7 @@ class OKULARCORE_EXPORT TextPage
/**
* Creates a new text page with the given @p words.
*/
TextPage( const TextEntity::List &words );
explicit TextPage( const TextEntity::List &words );
/**
* Destroys the text page.
......
......@@ -181,10 +181,10 @@ void EmbeddedFilesDialog::viewFile( Okular::EmbeddedFile* ef )
// using QTemporaryFile's XXXXXX placeholder
QTemporaryFile *tmpFile = new QTemporaryFile(
QDir::tempPath()
+ "/"
+ '/'
+ fileInfo.baseName()
+ ".XXXXXX"
+ (fileInfo.completeSuffix().isEmpty() ? QLatin1String("") : QString("." + fileInfo.completeSuffix()))
+ (fileInfo.completeSuffix().isEmpty() ? QLatin1String("") : QString('.' + fileInfo.completeSuffix()))
);
GuiUtils::writeEmbeddedFile( ef, this, *tmpFile );
......
......@@ -121,7 +121,7 @@ LatexRenderer::Error LatexRenderer::handleLatex( QString& fileName, const QStrin
tempFile->open();
QString tempFileName = tempFile->fileName();
QFileInfo *tempFileInfo = new QFileInfo(tempFileName);
QString tempFileNameNS = tempFileInfo->absolutePath() + "/" + tempFileInfo->baseName();
QString tempFileNameNS = tempFileInfo->absolutePath() + '/' + tempFileInfo->baseName();
QString tempFilePath = tempFileInfo->absolutePath();
delete tempFileInfo;
QTextStream tempStream(tempFile);
......
......@@ -41,7 +41,7 @@ class Page;
class PageViewItem
{
public:
PageViewItem( const Okular::Page * page );
explicit PageViewItem( const Okular::Page * page );
~PageViewItem();
PageViewItem(const PageViewItem &) = delete;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment